Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect a possible divide by zero in w3src4 #519

Merged

Conversation

JessicaMeixner-NOAA
Copy link
Collaborator

Pull Request Summary

Bug fix for protecting a possible divide by zero in w3src4

Description

When using ST4 physics, it's possible to attempt to divide by a zero ustar. This update protects this possibility and defines a z0 value for the case if ustar=0.

Issue(s) addressed

Check list

Commit Message

  • Protect a possible divide by zero ustar in w3src4

Testing

  • How were these changes tested? We are now able to run ww3_ufs_01 (and the fully coupled model) with debug flags (which is how this bug was originally found).
  • Are the changes covered by regression tests? No, we don't run w/debug flags every time.
  • If a new feature was added, was a new regression test added? No new feature
  • Have regression tests been run? Yes (w/an earlier develop)
  • Which compiler / HPC you used to run the regression tests in the PR? NCEP hera.intel
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

matrixCompSummary.txt
matrixCompFull.txt
matrixDiff.txt

Expected not b4b diffs:

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR2_UQ_MPI_d2                     (8 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (6 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (8 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (8 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (8 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (8 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (8 files differ)
mww3_test_07/./work_PR3_UQ                     (3 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (4 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (3 files differ)
ww3_ufs1.1/./work_d                     (0 files differ)
ww3_ufs1.2/./work_b                     (0 files differ)
ww3_ufs1.3/./work_a                     (1 files differ)
  • Please list which labels code managers should add to indicate code changes:
    no expected code changes

@aliabdolali
Copy link
Contributor

The test ran successfully on NOAA RDHPC with pre-known non-b4b tests:

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR2_UQ_MPI_d2                     (6 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (6 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (8 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (9 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (10 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (8 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (8 files differ)
mww3_test_07/./work_PR3_UQ                     (3 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (6 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (5 files differ)
ww3_ufs1.1/./work_d                     (0 files differ)
ww3_ufs1.2/./work_b                     (0 files differ)
ww3_ufs1.3/./work_a                     (1 files differ)
 

matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt

@aliabdolali aliabdolali merged commit b3462ba into NOAA-EMC:develop Nov 5, 2021
@JessicaMeixner-NOAA JessicaMeixner-NOAA deleted the debug/ST4dividebyzerofix branch November 13, 2021 12:34
JessicaMeixner-NOAA added a commit that referenced this pull request Nov 17, 2021
Protect a possible divide by zero ustar in w3src4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Divide by zero errors in w3src4md
4 participants