Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update internal to 0.10.5 #18

Merged
merged 243 commits into from
Aug 24, 2023
Merged

Update internal to 0.10.5 #18

merged 243 commits into from
Aug 24, 2023

Conversation

maiarareinaldo
Copy link
Collaborator

@maiarareinaldo maiarareinaldo commented Aug 22, 2023

Description

Updating internal branch with 0.10.5 changes. Also had to bring some other changes to fix issues:

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

jinlintt and others added 30 commits June 13, 2023 13:57
…atahub-project#8216)

Co-authored-by: Adrián Pertíñez <khurzak92@gmail.com>
Co-authored-by: Harshal Sheth <hsheth2@gmail.com>
…tahub-project#8240)

Co-authored-by: Indy Prentice <indy@Indys-MacBook-Pro.local>
Co-authored-by: Shirshanka Das <shirshanka@apache.org>
Co-authored-by: Shirshanka Das <shirshanka@apache.org>
Co-authored-by: david-leifker <114954101+david-leifker@users.noreply.github.com>
…roject#8225)

Co-authored-by: MohdSiddiqueBagwan <mohdsiddique.bagwan@gslab.com>
…nges (datahub-project#8200)

Co-authored-by: david-leifker <114954101+david-leifker@users.noreply.github.com>
…ation(tiles/pages) (datahub-project#8212)

Co-authored-by: MohdSiddiqueBagwan <mohdsiddique.bagwan@gslab.com>
…e instead (datahub-project#8201)

Co-authored-by: mohdsiddique <mohdsiddiquebagwan@gmail.com>
Co-authored-by: Harshal Sheth <hsheth2@gmail.com>
…nts when ingesting (datahub-project#8250)

Co-authored-by: Indy Prentice <indy@Indys-MacBook-Pro.local>
// Add new plugins here
);

this.graphQLPlugins.forEach(plugin -> plugin.init(args));

Check warning

Code scanning / QDJVMC

Redundant operation on empty container Warning

Collection this.graphQLPlugins is always empty
@@ -555,6 +578,14 @@
ownershipType
);
this.loadableTypes = new ArrayList<>(entityTypes);
// Extend loadable types with types from the plugins
// This allows us to offer search and browse capabilities out of the box for those types
for (GmsGraphQLPlugin plugin: this.graphQLPlugins) {

Check warning

Code scanning / QDJVMC

Redundant operation on empty container Warning

Collection this.graphQLPlugins is always empty
@maiarareinaldo maiarareinaldo marked this pull request as ready for review August 24, 2023 08:59
@maiarareinaldo maiarareinaldo changed the title Update internal attempt 2 Update internal to 0.10.5 Aug 24, 2023
@maiarareinaldo maiarareinaldo merged commit f907217 into internal Aug 24, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet