Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): make quickstart robust to docker race conditions #8233

Merged
merged 1 commit into from
Jun 14, 2023
Merged

fix(cli): make quickstart robust to docker race conditions #8233

merged 1 commit into from
Jun 14, 2023

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Jun 13, 2023

Also capture command durations as part of telemetry.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@hsheth2
fix(cli): make quickstart robust to docker race conditions
3a44488 
Also capture command durations as part of telemetry.
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jun 13, 2023
shirshanka
shirshanka approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 1528935 into datahub-project:master Jun 14, 2023
44 checks passed
@hsheth2 hsheth2 deleted the docker-quickstart-telemetry branch June 14, 2023 06:49
tusharm pushed a commit to tusharm/datahub that referenced this pull request Jun 20, 2023
@hsheth2 @tusharm
fix(cli): make quickstart robust to docker race conditions (datahub-p…
84eb7b8 
…roject#8233)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @shirshanka