Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(search): tag/term should filter for both entity and field level #7881

Merged
merged 3 commits into from
Jun 14, 2023
Merged

fix(search): tag/term should filter for both entity and field level #7881

merged 3 commits into from
Jun 14, 2023

Conversation

anshbansal
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Apr 21, 2023
@anshbansal anshbansal marked this pull request as ready for review April 21, 2023 14:02
chriscollins3456
chriscollins3456 approved these changes May 1, 2023
View reviewed changes
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@anshbansal
Copy link
Collaborator Author

the build has been failing because some server has connectivity issues. Has been happening a lot today. Will check tomorrow and re-run them

@anshbansal
Copy link
Collaborator Author

Looks like the cypress test is failing because the tag that I added for this purpose is not appearing when every other test is running. Or something else. Will need to check what is happening here before merging the PR in

@anshbansal anshbansal marked this pull request as draft May 2, 2023 13:36
@anshbansal anshbansal force-pushed the aseem-fix-recommedation-filters branch from 2273a93 to 7f69774 Compare June 13, 2023 13:09
@anshbansal anshbansal marked this pull request as ready for review June 13, 2023 13:10
@anshbansal anshbansal merged commit 5fc6601 into master Jun 14, 2023
34 checks passed
@anshbansal anshbansal deleted the aseem-fix-recommedation-filters branch June 14, 2023 08:31
tusharm pushed a commit to tusharm/datahub that referenced this pull request Jun 20, 2023
@anshbansal @tusharm
fix(search): tag/term should filter for both entity and field level (d…
634d67e 
…atahub-project#7881)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriscollins3456 chriscollins3456 chriscollins3456 approved these changes

Assignees
No one assigned
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anshbansal @chriscollins3456