Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): Call validator on the base urn as well as aspect components when ingesting #8250

Merged
merged 4 commits into from
Jun 16, 2023
Merged

fix(ingest): Call validator on the base urn as well as aspect components when ingesting #8250

merged 4 commits into from
Jun 16, 2023

Conversation

iprentic
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added devops PR or Issue related to DataHub backend & deployment product PR or Issue related to the DataHub UI/UX labels Jun 16, 2023
@iprentic iprentic merged commit e35ac44 into master Jun 16, 2023
35 checks passed
@iprentic iprentic deleted the nd-validate-root-urn branch June 16, 2023 16:47
tusharm pushed a commit to tusharm/datahub that referenced this pull request Jun 20, 2023
@iprentic @tusharm
fix(ingest): Call validator on the base urn as well as aspect compone…
b350872 
…nts when ingesting (datahub-project#8250)

Co-authored-by: Indy Prentice <indy@Indys-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanHolstien RyanHolstien RyanHolstien approved these changes

@david-leifker david-leifker Awaiting requested review from david-leifker

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iprentic @RyanHolstien