Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ignoring of certain upstream lineage platforms #15

Merged
merged 3 commits into from
Aug 11, 2023

Conversation

luos-fc
Copy link

@luos-fc luos-fc commented Aug 11, 2023

Adds the ability to ignore certain platforms for upstream lineage.

@@ -438,6 +444,11 @@ def __init__(
# when emitting custom SQL data sources.
self.custom_sql_ids_being_used: List[str] = []

if self.config.ignore_upstream_lineage_platforms:
self.ignore_upstream_lineage_platforms = (
self.config.ignore_upstream_lineage_platforms.split(",")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also trim in case people use spaces?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point!

Copy link
Collaborator

@maiarareinaldo maiarareinaldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@luos-fc luos-fc merged commit 3d7e2ab into internal Aug 11, 2023
6 checks passed
maiarareinaldo pushed a commit that referenced this pull request Aug 11, 2023
* Allow ignoring of certain upstream lineage platforms

* Handle whitespace

* Remove lineage_platform_instance
maiarareinaldo pushed a commit that referenced this pull request Aug 11, 2023
* Allow ignoring of certain upstream lineage platforms

* Handle whitespace

* Remove lineage_platform_instance
maiarareinaldo pushed a commit that referenced this pull request Aug 22, 2023
* Allow ignoring of certain upstream lineage platforms

* Handle whitespace

* Remove lineage_platform_instance
maiarareinaldo pushed a commit that referenced this pull request Feb 20, 2024
* Allow ignoring of certain upstream lineage platforms

* Handle whitespace

* Remove lineage_platform_instance
maiarareinaldo pushed a commit that referenced this pull request Feb 20, 2024
* Allow ignoring of certain upstream lineage platforms

* Handle whitespace

* Remove lineage_platform_instance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants