[GDP-1363] Switch on nested meta-mapping permanently (#15)

FundingCircle · Aug 22, 2023 · 3f29afe · 3f29afe
1 parent 07e1068
commit 3f29afe
Show file tree

Hide file tree

Showing 6 changed files with 11,194 additions and 6 deletions.
diff --git a/metadata-ingestion/src/datahub/ingestion/source/confluent_schema_registry.py b/metadata-ingestion/src/datahub/ingestion/source/confluent_schema_registry.py
@@ -69,14 +69,12 @@ def __init__(
             self.source_config.tag_prefix,
             "SOURCE_CONTROL",
             self.source_config.strip_user_ids_from_email,
-            match_nested_props=True,
         )
         self.field_meta_processor = OperationProcessor(
             self.source_config.field_meta_mapping,
             self.source_config.tag_prefix,
             "SOURCE_CONTROL",
             self.source_config.strip_user_ids_from_email,
-            match_nested_props=True,
         )
 
     @classmethod

diff --git a/metadata-ingestion/src/datahub/utilities/mapping.py b/metadata-ingestion/src/datahub/utilities/mapping.py
@@ -96,13 +96,11 @@ def __init__(
         tag_prefix: str = "",
         owner_source_type: Optional[str] = None,
         strip_owner_email_id: bool = False,
-        match_nested_props: bool = False,
     ):
         self.operation_defs = operation_defs
         self.tag_prefix = tag_prefix
         self.strip_owner_email_id = strip_owner_email_id
         self.owner_source_type = owner_source_type
-        self.match_nested_props = match_nested_props
 
     def process(self, raw_props: Dict[str, Any]) -> Dict[str, Any]:
         # Defining the following local variables -
@@ -127,7 +125,7 @@ def process(self, raw_props: Dict[str, Any]) -> Dict[str, Any]:
                     continue
 
                 raw_props_value = raw_props.get(operation_key)
-                if not raw_props_value and self.match_nested_props:
+                if not raw_props_value:
                     try:
                         raw_props_value = reduce(
                             operator.getitem, operation_key.split("."), raw_props