Skip to content

Commit

Permalink
Merge branch 'internal' into GDP-1768-1
Browse files Browse the repository at this point in the history
  • Loading branch information
maiarareinaldo committed Aug 22, 2023
2 parents db70722 + 3d7e2ab commit 0a38c96
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 9 deletions.
3 changes: 0 additions & 3 deletions metadata-ingestion/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,6 @@ coverage.xml
.pytest_cache/
junit.*xml

# Integration tests artifacts
tests/integrations/

# Translations
*.mo
*.pot
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,12 @@
from datahub.ingestion.api.workunit import MetadataWorkUnit
from datahub.ingestion.source.common.subtypes import DatasetSubTypes
from datahub.ingestion.source.sql.sql_types import (
ATHENA_SQL_TYPES_MAP,
BIGQUERY_TYPES_MAP,
POSTGRES_TYPES_MAP,
SNOWFLAKE_TYPES_MAP,
SPARK_SQL_TYPES_MAP,
TRINO_SQL_TYPES_MAP,
VERTICA_SQL_TYPES_MAP,
resolve_athena_modified_type,
resolve_postgres_modified_type,
resolve_trino_modified_type,
resolve_vertica_modified_type,
Expand Down Expand Up @@ -507,7 +505,6 @@ def get_upstream_lineage(upstream_urns: List[str]) -> UpstreamLineage:
**BIGQUERY_TYPES_MAP,
**SPARK_SQL_TYPES_MAP,
**TRINO_SQL_TYPES_MAP,
**ATHENA_SQL_TYPES_MAP,
**VERTICA_SQL_TYPES_MAP,
}

Expand All @@ -521,11 +518,9 @@ def get_column_type(
TypeClass: Any = _field_type_mapping.get(column_type)

if TypeClass is None:
# resolve a modified type
# resolve modified type
if dbt_adapter == "trino":
TypeClass = resolve_trino_modified_type(column_type)
elif dbt_adapter == "athena":
TypeClass = resolve_athena_modified_type(column_type)
elif dbt_adapter == "postgres" or dbt_adapter == "redshift":
# Redshift uses a variant of Postgres, so we can use the same logic.
TypeClass = resolve_postgres_modified_type(column_type)
Expand Down

0 comments on commit 0a38c96

Please sign in to comment.