Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest/unity): Set external url for containers and datasets #8238

Merged
merged 2 commits into from
Jun 15, 2023
Merged

feat(ingest/unity): Set external url for containers and datasets #8238

merged 2 commits into from
Jun 15, 2023

Conversation

asikowitz
Copy link
Collaborator

@asikowitz asikowitz commented Jun 14, 2023 •
edited
Loading

Review #8237 first. Have to rebase once the other one is merged. Just review the last commit.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jun 14, 2023
treff7es
treff7es approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@treff7es treff7es merged commit 66806a8 into datahub-project:master Jun 15, 2023
43 of 44 checks passed
@asikowitz asikowitz deleted the unity-external-url branch June 15, 2023 23:07
@asikowitz asikowitz mentioned this pull request Jun 18, 2023
Closed
5 tasks
tusharm pushed a commit to tusharm/datahub that referenced this pull request Jun 20, 2023
@asikowitz @tusharm
feat(ingest/unity): Set external url for containers and datasets (dat…
ff6eb4a 
…ahub-project#8238)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asikowitz @treff7es @hsheth2