Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy Checklist: New Expensify 2022-02-15 #7759

Closed
85 tasks done
OSBotify opened this issue Feb 15, 2022 · 38 comments
Closed
85 tasks done

Deploy Checklist: New Expensify 2022-02-15 #7759

OSBotify opened this issue Feb 15, 2022 · 38 comments
Assignees
@applausebot
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Feb 15, 2022 •
edited by Stutikuls
Loading

Release Version: 1.1.39-3
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

cc @Expensify/applauseleads
@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Feb 15, 2022
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.39-1 🚀

@roryabraham
Copy link
Contributor

Verified #7614 internally, checking it off.

@mountiny
Copy link
Contributor

Checking #7672 off since it is a procedural PR. It seems like it is still some issue but it is not blocking anything so it can be checked off.

@NikkiWines
Copy link
Contributor

Checking QA for #7681 off since I was able to test and confirm it works as anticipated

@roryabraham
Copy link
Contributor

Whoa, lots of deploy blockers 😬

@roryabraham
Copy link
Contributor

I was not able to reproduce #7776 on any platform. Can we please retest?

@mvtglobally
Copy link

@roryabraham Will check and confirm

@roryabraham

This comment was marked as off-topic.

Sign in to view
@roryabraham

This comment was marked as off-topic.

Sign in to view
@roryabraham

This comment was marked as off-topic.

Sign in to view
@mvtglobally
Copy link

Regression is completed
#7577 is failing #7763
#7776 is still reproduced by the team

Deploy Blockers still open
#7774
#7775
#7776

Other Issues logged
#7786
#7781
#7780
#7779
#7777
#7773
#7770
#7768
#7764
#7763

@mvtglobally
Copy link

Just added 1 more deploy blocker. #7811

@Julesssss
Copy link
Contributor

I'm checking off #7577 as we do not think #7763 is a bug, but expected behavior.

@Julesssss
Copy link
Contributor

For #7776 I removed the deployBlocker label as we're not able to reproduce on Desktop staging or dev.

@Julesssss
Copy link
Contributor

I tried verifying a potential fix for #7769 & #7774, but I've had a whole heap of problems. it looks like the issue itself will resolve the blocker though. I have asked for help with testing in #engineering-chat

@MelvinBot MelvinBot added the Monthly KSv2 label Feb 18, 2022
@mvtglobally
Copy link

How are we looking on the possibility to get a new build today?

@timszot
Copy link
Contributor

timszot commented Feb 22, 2022

@mvtglobally Looking into the three remaining blockers, looks like there is one PR that should fix it, getting that moving today!

@timszot
Copy link
Contributor

timszot commented Feb 22, 2022

@mvtglobally the PR to clear the blockers is merged and added to the list. Can you please get things re-tested and then we can push this deploy out!

@mvtglobally
Copy link

Working on it

@mvtglobally
Copy link

Checking off the following as they are no longer blockers #7772 (comment), #7811, #7784,

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.39-3 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.39-3 has been deployed to staging 🎉

@mvtglobally
Copy link

mvtglobally commented Feb 23, 2022 •
edited
Loading

@timszot, Multiple new issues found while validating #7782. None seem to be blockers since they are repro in PROD, but pls double check. PR is failing due to the same
#7868
#7869
#7872

@mvtglobally
Copy link

Checking off #7774,7775 they no longer reproducible

@timszot
Copy link
Contributor

timszot commented Feb 23, 2022

OK, let me make sure I've got this straight....

It looks to me that we have 4 items on this checklist to finish up:

PR: #7782

InternalQA: #7802 & #7672

  • I will figure out the status, but it seems that this comment is a good enough test for the first one.

@timszot timszot mentioned this issue Feb 23, 2022
Merged
@timszot timszot mentioned this issue Feb 23, 2022
Merged
4 tasks
@mvtglobally
Copy link

mvtglobally commented Feb 23, 2022 •
edited
Loading

@timszot We are blocked to check #7769 because of the error #7868. We are unable to make any payment default at this time.
Screen Shot 2022-02-23 at 10 42 12 AM

@mvtglobally
Copy link

@timszot @roryabraham
Can you discuss internally, if we don't think we can get a new deploy today, let's consider removing Lock label and adding more PRs to the pool? And maybe running another regression on the same 1.1.39-x build?
Last deploy was more than a week ago and I really don't want the Pr list to pile up and testers waiting. Let me know what you think.

@parasharrajat
Copy link
Member

parasharrajat commented Feb 23, 2022 •
edited
Loading

#7769 is fixed by #7782.

To test #7782, the app should not crash.

#7868 was present on main since the past few versions and I don't think it is a deploy blocker. Also, I think this is behind beta.

@roryabraham
Copy link
Contributor

@mvtglobally We discussed internally and we don't want to open the floodgates to more pull requests, as that will likely only increase the time until the next deploy. We want to get the deploy out ASAP as all the contributors with PR's in this checklist are waiting for their work to be deployed to production so they can be compensated.

@timszot
Copy link
Contributor

timszot commented Feb 23, 2022

Alright, tested the default payment option on iOS 1.1.39-3 and it worked

@timszot
Copy link
Contributor

timszot commented Feb 23, 2022

We should be all clear! :shipit:

@timszot timszot closed this as completed Feb 23, 2022
@OSBotify OSBotify reopened this Feb 23, 2022
@OSBotify
Copy link
Contributor Author

This issue either has unchecked QA steps or has not yet been marked with the :shipit: emoji of approval.
Reopening!

@michaelhaxhiu
Copy link
Contributor

Just to be 100% sure I'm following, we have no remaining deploy blockers?

@timszot
Copy link
Contributor

timszot commented Feb 23, 2022

Just to be 100% sure I'm following, we have no remaining deploy blockers?

Correct, the last blocker was #7769 which was fixed by #7782

@timszot
Copy link
Contributor

timszot commented Feb 23, 2022

:shipit:

@timszot timszot closed this as completed Feb 23, 2022
@michaelhaxhiu
Copy link
Contributor

michaelhaxhiu commented Feb 23, 2022 via email

@Stutikuls
Copy link

Stutikuls commented Mar 7, 2022 •
edited
Loading

Checked all PRs and added comments on all PRs where accessibility issue were found.
The non-applicable PRs are - #7318 #7614 #7632 #7658 #7673 #7684
Impossibility to verify (After client confirmation) #7681 #7684

@SumitDiyora
Copy link

SumitDiyora commented Mar 8, 2022 •
edited
Loading

Checked all PRs and added comments to all PRs where accessibility issues were found.
The non-applicable PRs are - #7692 #7693 #7695 #7696 #7698 #7700 #7705 #7716 #7719 #7743 #7747 #7754
Impossibility to verify (After client confirmation) #7713

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@applausebot applausebot

Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests