Translate alternate text to Spanish #7552

sobitneupane · 2022-02-03T17:09:02Z

Details

[Attachment] alternate text in LHN is not translated to Spanish

Fixed Issues

$ #7440

Tests

Send attachment
Change language to Spanish and check at LHN. [Attachment] alternate text should be translated.

QA Steps

Send attachment
Change language to Spanish and check at LHN. [Attachment] alternate text should be translated.

Tested On

Screenshots

Web

attachment-translation.mp4

Mobile Web

Desktop

iOS

Android

src/libs/actions/Report.js

src/components/OptionsList/BaseOptionsList.js

parasharrajat · 2022-02-07T08:41:11Z

src/libs/OptionsListUtils.js

        ? (hasMultipleParticipants && lastActorDetails
            ? `${lastActorDetails.displayName}: `
            : '')
-        + Str.htmlDecode(report.lastMessageText)
+        + (isLastMessageAttachment ? `[${Localize.translateLocal('common.attachment')}]` : Str.htmlDecode(report.lastMessageText))


Could we please simplify this ternary? lets not nest it multi levels.

This should be okay. Any suggestion?

const lastMessageTextFromReport = isLastMessageAttachment ? `[${Localize.translateLocal('common.attachment')}]` : Str.htmlDecode(report.lastMessageText); const lastMessageText = report ? (hasMultipleParticipants && lastActorDetails ? `${lastActorDetails.displayName}: ` : '') + (lastMessageTextFromReport) : '';

Let's break the concatenation into the next line.

const lastMessageTextFromReport = isLastMessageAttachment ? `[${Localize.translateLocal('common.attachment')}]` : Str.htmlDecode(report.lastMessageText); let lastMessageText = report && hasMultipleParticipants && lastActorDetails ? `${lastActorDetails.displayName}: ` : ''; lastMessageText += report? lastMessageTextFromReport : '';

parasharrajat · 2022-02-09T14:26:05Z

src/libs/OptionsListUtils.js

@@ -221,17 +221,17 @@ function createOption(personalDetailList, report, {
    const personalDetail = personalDetailList[0];
    const hasDraftComment = hasReportDraftComment(report);
    const hasOutstandingIOU = lodashGet(report, 'hasOutstandingIOU', false);
+    const isLastMessageAttachment = report ? ReportUtils.isReportMessageAttachment(report.lastMessageText) : false;


Suggested change

const isLastMessageAttachment = report ? ReportUtils.isReportMessageAttachment(report.lastMessageText) : false;

parasharrajat · 2022-02-09T14:26:33Z

src/libs/OptionsListUtils.js

-            ? `${lastActorDetails.displayName}: `
-            : '')
-        + Str.htmlDecode(report.lastMessageText)
+    const lastMessageTextFromReport = report && (isLastMessageAttachment ? `[${Localize.translateLocal('common.attachment')}]` : Str.htmlDecode(report.lastMessageText));


Suggested change

const lastMessageTextFromReport = report && (isLastMessageAttachment ? `[${Localize.translateLocal('common.attachment')}]` : Str.htmlDecode(report.lastMessageText));

const lastMessageTextFromReport = ReportUtils.isReportMessageAttachment(lodashGet(report, 'lastMessageText','')) ? `[${Localize.translateLocal('common.attachment')}]` : Str.htmlDecode(lodashGet(report, 'lastMessageText',''));

parasharrajat

LGTM.

cc: @roryabraham
🎀 👀 🎀 C+ reviewed

parasharrajat · 2022-02-09T15:44:55Z

@sobitneupane Please tick all the platforms on the template and attach screenshots for all.

sobitneupane · 2022-02-09T16:01:41Z

@sobitneupane Please tick all the platforms on the template and attach screenshots for all.

okay

roryabraham · 2022-02-10T06:46:10Z

@sobitneupane I have one small tip for you to keep in mind for the future. When adding screenshots in the pull request description, GitHub has a tendency to make the images way too big, especially when pasting a screenshot of a mobile device/simulator.

I find it very helpful to adjust those images to a more reasonable size by either:

Using a hard-coded html img tag instead of GH's default markdown:

- ![Screenshot_20220203-212457_Chrome](https://user-images.githubusercontent.com/25876548/152380678-4cff0b29-102e-4fac-9cac-9a5527e61e8b.jpg)
+ <img src="https://user-images.githubusercontent.com/25876548/152380678-4cff0b29-102e-4fac-9cac-9a5527e61e8b.jpg" alt="" width="350px" />

Or (even better in this case) using a markdown table to store screenshots:

English	Español

This is helpful not only to reviewers, but also to our QA team. Thanks!

OSBotify · 2022-02-10T06:47:01Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

sobitneupane · 2022-02-10T07:34:33Z

Thanks for the suggestion. Will definitely take care moving forward.

OSBotify · 2022-02-15T19:33:16Z

🚀 Deployed to staging by @roryabraham in version: 1.1.39-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2022-02-23T21:22:35Z

🚀 Deployed to production by @timszot in version: 1.1.39-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Stutikuls · 2022-03-04T12:01:10Z

Issue 1 -

Title- [Medium]: Voiceover +Safari: Screen reader : Screen reader is not reading the Role, State & Value for the 'Language' control.
Actual - When focus lands on the Language control then screen reader is only reading "Language" and focus lands on the label, value of the control individually and multiple times.
Expected - Role = Drop down, State = Collapsed/expanded, Value = English. Focus should land on the control only once and when focus lands on the control then screen reader should read like "Language English drop down button collapsed".
WCAG failure - 4.1.2
Reproducible in staging?: - Yes
Version Number: - v1.1.39-3
Platforms - iOS

7552_Screen.reader.is.not.reading.the.Role.State.Value.for.the.Language.control.MOV

Issue 2 -

Title- [Medium]:Chrome +Jaws: Screen reader : Screen reader is not reading the Label along with the value.
Actual - When focus lands on the Language control then screen reader is reading "English", not reading the name of the control along with the value.
Expected - Screen reader should read like "Language English drop down button collapsed".
WCAG failure - 1.3.1
Reproducible in staging?: - Yes
Version Number: - v1.1.39-3
Platforms - Web

7552_Label.is.not.associated.with.the.value.of.the.combo.box.mp4

Issue 3 -

Title- [Medium]: Chrome +Talkback: Screen reader : Focus stuck on the 'Language' control twice.
Actual - Focus lands on the language control twice. first time its reading "English edit box disable" and 2nd time screen reader is reading "Language".
Expected - Focus should stay on the control only once and screen reader should read like "Language English drop down button collapsed".
WCAG failure - 2.4.3
Reproducible in staging?: - Yes
Version Number: - v1.1.44-3
Platforms - Android

7552_Stuck.twice.mp4

Issue 4 -

Title- [Medium]: Talkback+ Chrome: Screen reader : Incorrect role and state is defined for the 'Language' control.
Actual - When focus lands on the Language control then screen reader is reading "English edit box disable" and 2nd time screen reader is reading "Language" and focus lands on the label, value of the control individually.
Expected - Role = Drop down, State = Collapsed/expanded, Value = English. Focus should land on the control only once and when focus lands on the control then screen reader should read like "Language English drop down button collapsed".
WCAG failure - 4.1.2
Reproducible in staging?: - Yes
Version Number: - v1.1.44-3
Platforms - Android

7552_Incorrect.state.mp4

Issue 5 -

Title- [Medium]: Talkback+ Chrome: Screen reader :'Language' control drop down is not accessible using screen reader.
Actual - When focus lands on the Language control then screen reader is reading "English edit box disable" and 2nd time screen reader is reading "Language" but control is not activate after press double Tap on it.
Expected - Language' control drop down should accessible using screen reader.
WCAG failure - 2.1.1
Reproducible in staging?: - Yes
Version Number: - v1.1.44-3
Platforms - Android

7552_2.1.1_.Language.control.drop.down.is.not.accessible.using.screen.reader.mp4

Translate alternate text to Spanish

cf9d0af

sobitneupane requested a review from a team as a code owner February 3, 2022 17:09

MelvinBot requested review from parasharrajat and roryabraham and removed request for a team February 3, 2022 17:09

parasharrajat suggested changes Feb 3, 2022

View reviewed changes

src/libs/actions/Report.js Outdated Show resolved Hide resolved

parasharrajat suggested changes Feb 4, 2022

View reviewed changes

src/components/OptionsList/BaseOptionsList.js Outdated Show resolved Hide resolved

Set alternateText to Attachment from OptionsListUtils if Attachment

64dab20

parasharrajat suggested changes Feb 7, 2022

View reviewed changes

Simplify ternary operator in lastMessageText

6188268

parasharrajat suggested changes Feb 9, 2022

View reviewed changes

Syntatic Change in lastMessageTextFromReport

8ff224d

parasharrajat approved these changes Feb 9, 2022

View reviewed changes

roryabraham approved these changes Feb 10, 2022

View reviewed changes

roryabraham merged commit bdf3a74 into Expensify:main Feb 10, 2022

OSBotify mentioned this pull request Feb 15, 2022

Deploy Checklist: New Expensify 2022-02-15 #7759

Closed

85 tasks

This was referenced Feb 15, 2022

LHN - [Comment Deleted] text translated in Spanish after refresh the page #7764

Closed

Send Money - "Delete comment" appears instead of sent $ money in LHN after refresh the page #7773

Closed

adelekennedy mentioned this pull request Feb 21, 2022

[HOLD for payment 2022-03-02] [Attachment] alternate text in LHN is not translated to Spanish - reported by @sobitneupane #7440

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Translate alternate text to Spanish #7552

Translate alternate text to Spanish #7552

sobitneupane commented Feb 3, 2022 •

edited

Loading

parasharrajat Feb 7, 2022

sobitneupane Feb 8, 2022 •

edited

Loading

parasharrajat Feb 8, 2022

parasharrajat Feb 9, 2022

parasharrajat Feb 9, 2022

parasharrajat left a comment

parasharrajat commented Feb 9, 2022

sobitneupane commented Feb 9, 2022

roryabraham commented Feb 10, 2022

OSBotify commented Feb 10, 2022

sobitneupane commented Feb 10, 2022

OSBotify commented Feb 15, 2022

OSBotify commented Feb 23, 2022

Stutikuls commented Mar 4, 2022 •

edited

Loading

	const lastMessageTextFromReport = report && (isLastMessageAttachment ? `[${Localize.translateLocal('common.attachment')}]` : Str.htmlDecode(report.lastMessageText));
	const lastMessageTextFromReport = ReportUtils.isReportMessageAttachment(lodashGet(report, 'lastMessageText','')) ? `[${Localize.translateLocal('common.attachment')}]` : Str.htmlDecode(lodashGet(report, 'lastMessageText',''));

Translate alternate text to Spanish #7552

Translate alternate text to Spanish #7552

Conversation

sobitneupane commented Feb 3, 2022 • edited Loading

Details

Fixed Issues

Tests

QA Steps

Tested On

Screenshots

Web

Mobile Web

Desktop

iOS

Android

parasharrajat Feb 7, 2022

Choose a reason for hiding this comment

sobitneupane Feb 8, 2022 • edited Loading

Choose a reason for hiding this comment

parasharrajat Feb 8, 2022

Choose a reason for hiding this comment

parasharrajat Feb 9, 2022

Choose a reason for hiding this comment

parasharrajat Feb 9, 2022

Choose a reason for hiding this comment

parasharrajat left a comment

Choose a reason for hiding this comment

parasharrajat commented Feb 9, 2022

sobitneupane commented Feb 9, 2022

roryabraham commented Feb 10, 2022

OSBotify commented Feb 10, 2022

sobitneupane commented Feb 10, 2022

OSBotify commented Feb 15, 2022

OSBotify commented Feb 23, 2022

Stutikuls commented Mar 4, 2022 • edited Loading

sobitneupane commented Feb 3, 2022 •

edited

Loading

sobitneupane Feb 8, 2022 •

edited

Loading

Stutikuls commented Mar 4, 2022 •

edited

Loading