Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send Money - "Delete comment" appears instead of sent $ money in LHN after refresh the page #7773

Closed
kbecciv opened this issue Feb 16, 2022 · 13 comments
Assignees
Labels
Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff

Comments

@kbecciv
Copy link

kbecciv commented Feb 16, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Launch the app
  2. Log in with any account
  3. Open a chat with any user
  4. Click the "+" button and then "Send money"
    Screen Shot 2022-02-16 at 7 36 44 PM
  5. Enter any amount, then click "Next"
  6. Use the option "I'll settle up elsewhere" on drop down menu.
  7. Refresh the page

Expected Result:

Message displayed in LHN - "Sent $amount elsewhere

Actual Result:

"[Delete comment]" appears instead of sent $ money in LHN after refresh the page

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.39-1

Reproducible in staging?: Yes

Reproducible in production?: Yes

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.226.mp4
Bug5455431_Screen_Recording_20220215-215650_New_Expensify.mp4
Bug5455431_Image_from_iOS__15_.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

Issue was found when executing: #7552

View all open jobs on GitHub

@MelvinBot
Copy link

Triggered auto assignment to @aldo-expensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@aldo-expensify
Copy link
Contributor

aldo-expensify commented Feb 17, 2022

The report prop had the following value in my case:

{.  // report
    "hasIOUAction": true,
    "isPinned": false,
    "reportActionCount": 2,
    "lastActionActorEmail": "aldo+test-plaid-2@expensifail.com",
    "lastActionCreated": "2022-02-16 23:58:32",
    "lastActionMessage": {
        "IOUDetails": {
            "amount": 12300,
            "comment": "",
            "currency": "CAD"
        },
        "IOUReportID": 9090,
        "paymentType": "Elsewhere",
        "type": "pay"
    },
    "lastActionType": "IOU",
    ...
}

Since there is no report.lastActionMessage.html, the variable lastActionMessage gets initialized to '' here, then here, lastMessageText gets assigned [${Localize.translateLocal('common.deletedCommentMessage')}]

@aldo-expensify
Copy link
Contributor

Updated instructions with simpler steps

@aldo-expensify
Copy link
Contributor

Oh, it broke because of change in Web-E

@aldo-expensify aldo-expensify added the Internal Requires API changes or must be handled by Expensify staff label Feb 17, 2022
@MelvinBot
Copy link

Triggered auto assignment to @jliexpensify (Internal) because issue was reported by a contributor who needs to be compensated if this issue is fixed

@aldo-expensify
Copy link
Contributor

was it reported by a contributor?

@mvtglobally
Copy link

@aldo-expensify NOT reported by a Contributor. Our team noticed it and @joekaufmanexpensify raised it as well in Slack

@jliexpensify
Copy link
Contributor

@aldo-expensify - no need to create a job in Upworks right? Is this being handled internally?

@aldo-expensify
Copy link
Contributor

@jliexpensify nop, no need to create job in Upworks.

@jliexpensify
Copy link
Contributor

Cheers Aldo, going to unassign myself!

@aldo-expensify
Copy link
Contributor

No overdue, PR merged, but not deployed yet

@MelvinBot MelvinBot added Overdue and removed Overdue labels Feb 24, 2022
@aldo-expensify
Copy link
Contributor

No overdue, PR will be tested in Production

@aldo-expensify
Copy link
Contributor

aldo-expensify commented Mar 4, 2022

This was fixed in this PR, but a similar issue remains...

The last message [Comment deleted] only goes away after refresh, which is somewhat inconsistent.

Screen.Recording.2022-03-03.at.10.25.12.PM.mov

I think this has to be fixed in the front end, so I created new GH issue for it: #8001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

5 participants