Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General Settings - Character limit counter and hint to TextInput are not displayed for name field #7763

Closed
kbecciv opened this issue Feb 15, 2022 · 8 comments
Assignees

Comments

@kbecciv
Copy link

kbecciv commented Feb 15, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Launch App as login user
  2. Navigate to Workspace > General settings
  3. Clear field and start typing name

Expected Result:

Character limit counter and hint to TextInput are displayed for name field

Actual Result:

Character limit counter and hint to TextInput are not displayed for name field

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.39-1

Reproducible in staging?: Yes

Reproducible in production?: Yes

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5455126_Counter.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

Issue was found when executing : #7577

View all open jobs on GitHub

@MelvinBot
Copy link

Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@iwiznia
Copy link
Contributor

iwiznia commented Feb 15, 2022

Do we limit the characters the policy name can have? If not, then I think this is not an issue and we should close this.

@iwiznia
Copy link
Contributor

iwiznia commented Feb 15, 2022

I don't see any limit on length of name, so this is not an issue.

@iwiznia iwiznia closed this as completed Feb 15, 2022
@isagoico
Copy link

isagoico commented Feb 17, 2022

@iwiznia This issue is failing QA for PR #7577.
Reopening the issue.
CC @parasharrajat

@isagoico isagoico reopened this Feb 17, 2022
@iwiznia
Copy link
Contributor

iwiznia commented Feb 17, 2022

This input does not have any limit, so I don't see why we would show the counter. Can you explain?

@parasharrajat
Copy link
Member

Yeah, I agree with @iwiznia. @iwiznia I added the new feature on #7577 but it is not added to any screens yet.

@Julesssss
Copy link
Contributor

Julesssss commented Feb 18, 2022

Hi @isagoico, I'm going to close this again and mark it off the list as this is expected behavior. I don't see how it is failing #7577 honestly.

Is there a test case that requires that we show the limit error? If so I think we can remove that from the test suit for now.

@isagoico
Copy link

Oh I got it now, my apologies I misread the QA steps and was confused with the testing screenshots. We usually compare the testing screenshots to verify the intended behavior and the ones added in the PR show the counter. Closing the issue then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants