-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add counter and hint to TextInput #7577
Conversation
Can you help me understand why you chose to make FormHelp a separate component. Is it because we plan to use the same form help text on other input types? |
Yeah, exactly. I think other components(picker, DatePicker, etc) will need the same to apply the correct margin and padding. So we will eventually give up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments
I'm not sure we will end up reusing this. Those inputs will most likely not require a hint nor character count. |
Changes done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a small comment. Can we also add a screenshot for iOS as well?
OK, Changes are done @luacmartins @puneetlath. Updated screenshots. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tested well! Thanks for the changes @parasharrajat! All yours @puneetlath.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @luacmartins in version: 1.1.39-0 🚀
|
Issue 1 - Title- [Medium]: Chrome+ Jaws : Screen reader :Role is not defined for the 'Save' control. 7577_Role.is.not.defined.for.Save.control.mp4Issue 2 - Title-[High] Chrome + Jaws: Screen reader : Error message is not announced by the screen reader 7577_Error.message.is.not.read.by.screen.reader.mp4Issue 3 - Title-[Medium] Chrome +Jaws: Screen reader : Status message is not being announced by screen reader 7577_Status.message.not.read.by.screen.reader.mp4 |
Details
Fixed Issues
$ #7522
Tests | QA Steps
Tested On
Screenshots
Web | Desktop
Mobile Web
iOS
Android