[HOLD for payment 2022-03-02] Implement display character limit counter and hint on TextInput

[luacmartins]

We should implement a character counter and hint to TextInput:

1. Add a maxLength={Int} prop. Defaults to null. Make sure this is passed down to RN's TextInput component.
2. Add a hint="string" prop. Defaults to an empty string.
3. Display the character counter and hint under the input.

Notes:

1. Inline errors should always replace the hints.
2. Hint copy should be padded on the left to align with input value and label.
3. Character counter should have the same padding on the left.

[MelvinBot]

Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[luacmartins]

Actually, we might use Applause to do this audit for us. Removing the External label.

[luacmartins]

Oops, this one is still external! My bad! Reassigning original contributor manager and re-adding the External label.

[MelvinBot]

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

[mateusbra]

@luacmartins currently we have inlineErrors formatted this way:

You think we should also change the behavior of inlineError styles to fit the provided images you gave us?(padding left)
The provided images has more padding left than the currently we use

[luacmartins]

@mateusbra inline errors aligning with labels and input value is the design going forward.

[puneetlath]

@luacmartins just to clarify, we just want a contributor to go ahead and implement these changes to our TextInput component right? I'm not quite sure I follow how Applause would be involved here.

[luacmartins]

Yes, correct. That comment was meant for another issue, sorry about the confusion!

[puneetlath]

Cool, no worries!

[puneetlath]

Since @parasharrajat is doing a bunch of work on consolidating our various TextInput components, it might make sense for him to include this. That seems like the least risky approach to me. @parasharrajat what do you think?

[parasharrajat]

Yeah, I can take it. And move this milestone to the top of the list so that it can be done early. I don't want to have conflicts at best.

[puneetlath]

Ok sounds good. I'll add it as a milestone to our existing Upwork job for the TextInput refactor.

[MelvinBot]

Current assignee @parasharrajat is eligible for the Exported assigner, not assigning anyone new.

[MelvinBot]

Current assignee @puneetlath is eligible for the Exported assigner, not assigning anyone new.

[luacmartins]

Not overdue! PR was merged, but not deployed yet.

[puneetlath]

Not overdue! PR was merged, but not deployed yet.

[puneetlath]

Awaiting production deploy.

[botify]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.39-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add counter and hint to TextInput #7577

If no regressions arise, payment will be issued on 2022-03-02. 🎊

[puneetlath]

Paid!