Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - VBA - Unable to enter date in company info and personal info page using date picker or manually #7774

Closed
kavimuru opened this issue Feb 16, 2022 · 8 comments
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Reviewing Has a PR in review

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Navigate to the add bank account modal
  2. Verify the Add bank account modal is displayed with 2 options to add bank accounts
  3. Select the log in method
    4.Verify the plaid modal is displayed.
    5.Select Wells Cargo
  4. Enter the test credentials
  5. Choose the savings account "Plaid Saving11122XXXXXX111"
  6. In the company information enter the information in this step
  7. In the Personal information step enter the information in this step

Expected Result:

I can enter data in Incorporate date section and DOB

Actual Result:

Unable to enter date in company info and personal info page using date picker or manually

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web

Version Number: 1.1.39-1
Reproducible in staging?: Y
Reproducible in production?: No ( We can't check production)
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5456020_Recording__421.mp4
Bug5456020_Recording__420.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

@kavimuru kavimuru added the DeployBlockerCash This issue or pull request should block deployment label Feb 16, 2022
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@neil-marcellini
Copy link
Contributor

👀

@neil-marcellini
Copy link
Contributor

neil-marcellini commented Feb 16, 2022

In BaseTextInput.js when setValue is called this.value is undefined and once it is set the text input seems to reset. I tried reverting #7722 and #7721 locally but that didn't fix it. I'll ask in Slack to see if anyone else has more context.

@neil-marcellini
Copy link
Contributor

I'm still trying to figure out where this.value gets set to undefined on the BaseTextInput.

@parasharrajat
Copy link
Member

parasharrajat commented Feb 16, 2022

It is a possible regression from my PR #7318. I am trying to fix it #7769. I will share update in an hour.

@parasharrajat
Copy link
Member

parasharrajat commented Feb 16, 2022

@neil-marcellini Could you please test this issue on #7782 branch? I can't follow the VBA flow.

@neil-marcellini
Copy link
Contributor

I can't either, but I've been just navigating to /bank-account/company which is where the problem occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

6 participants