Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #7609 - Long names were cut off on mWeb in Chat headers #7705

Merged
merged 2 commits into from
Feb 14, 2022
Merged

Fix #7609 - Long names were cut off on mWeb in Chat headers #7705

merged 2 commits into from
Feb 14, 2022

Conversation

sig5
Copy link
Contributor

@sig5 sig5 commented Feb 11, 2022 •
edited
Loading

Details

Fix for regression due to #7077

Fixed Issues

$ #7609

Tests

  • Verify the positioning of Empty state names for arbitrarily long names in chats and groups.
  • Verify that no errors appear in the JS console

QA Steps

  • Verify the positioning of Empty state names for arbitrarily long names in chats and groups.
  • Verify that no errors appear in the JS console

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screenshot 2022-02-10 12:24:25

Mobile Web

Screenshot 2022-02-10 12:23:42

Desktop

Screenshot from 2022-02-11 20-43-59

iOS

Screenshot from 2022-02-11 06-06-53

Android

Screenshot from 2022-02-11 20-10-53

@sig5 sig5 requested a review from a team as a code owner February 11, 2022 14:53
@MelvinBot MelvinBot requested review from marcaaron and parasharrajat and removed request for a team February 11, 2022 14:53
@sig5
Copy link
Contributor Author

sig5 commented Feb 11, 2022 •
edited
Loading

Mb, I added the wrong issue number in the beginning ( Sorry Marc ). @parasharrajat Should we tag Luke for review explicitly?

Also I am running into issues having the desktop app running for some reason. My changes certainly aren't the reason, So I posted my PR. Will update the Desktop as soon as I get it running.
Edit: Updated.

@sig5 sig5 changed the title Fix #7609 Fix #7609 - Long names were cut off on mWeb in Chat headers Feb 11, 2022
parasharrajat
parasharrajat approved these changes Feb 11, 2022
View reviewed changes
Copy link
Member

@parasharrajat parasharrajat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

cc: @Luke9389

🎀 👀 🎀 C+ reviewed

@marcaaron marcaaron requested review from Luke9389 and removed request for marcaaron February 14, 2022 18:55
@Luke9389 Luke9389 merged commit 5e37ec7 into Expensify:main Feb 14, 2022
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Feb 15, 2022
Closed
85 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Luke9389 in version: 1.1.39-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @timszot in version: 1.1.39-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@SumitDiyora SumitDiyora mentioned this pull request Mar 15, 2022
Closed
69 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parasharrajat parasharrajat parasharrajat approved these changes

@Luke9389 Luke9389 Luke9389 approved these changes

Assignees

@sig5 sig5

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sig5 @OSBotify @parasharrajat @Luke9389