Deploy Checklist: New Expensify 2022-01-04

[OSBotify]

Release Version: 1.1.25-1
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Allow redirect to MagicLink after Invalid Validation Code #5150

  • QA
  • Accessibility

• Selection scraper created and integrated to project #6732

  • QA
  • Accessibility

• Icon rounding issue resolved #6770

  • QA
  • Accessibility

• Show deleted comments in conversation history #6819

  • QA
  • Accessibility

• Update CONTRIBUTING.md #6887

  • QA
  • Accessibility

• Update guidelines on bugs not happening in production #6895

  • QA
  • Accessibility

• Make the current password field also submittable via Enter #6904

  • QA
  • Accessibility

• fix password input hint stylings #6905

  • QA
  • Accessibility

• [No QA] Fix api usage inside AddEncryptedAuthToken migration #6915

  • QA
  • Accessibility

• Add autoCapitalize prop to avoid first letter duplication on android #6916

  • QA
  • Accessibility

• [No QA] fix: Added translate key for street name based on the form #6930

  • QA
  • Accessibility

• [No QA] fix: null check for app state subscription added #6936

  • QA
  • Accessibility

• fix: Paypal address and Venmo phone number #6949

  • QA
  • Accessibility

• Update react-native-bootsplash to 3.2.7 #6950

  • QA
  • Accessibility

• fix: room page layout #6951

  • QA
  • Accessibility

• fix: Removed \n for different copies of change password #6954

  • QA
  • Accessibility

• [No QA]Generate a new GPG key and add it to the .gitignore #6957

  • QA
  • Accessibility

• [NO QA] Planned improvements may not be paid out #6968

  • QA
  • Accessibility

• fix: Changed copy for Desktop -> macOS #6973

  • QA
  • Accessibility

• Change tooltiptext of avatar in LHN to Settings #6976

  • QA
  • Accessibility

• fix: Add trim to searchValue in OptionsUtils #6993

  • QA
  • Accessibility

• [No QA] Fix broken ExpensifyText #7006

  • QA
  • Accessibility

Deploy Blockers:

• Password setup - Message is different when redirected to the magic link page after entering invalid validation code  #7030

cc @Expensify/applauseleads

[Jag96]

Putting a HOLD on this checklist, staging and production are still not up to date with 1.1.24-20 so we'll need to sort that out before QA can be run. cc @Expensify/mobile-deployers

[mvtglobally]

@Jag96, please ping me once it ready. We will only be able to start tomorrow morning as it's late now anyway.

[mvtglobally]

@Jag96 @roryabraham Are we ok to start QA?

[roryabraham]

Not yet – I've proposed a plan but because I was ooo for all the deploy failures yesterday I want to get a 👍 from @francoisl or @Jag96 before proceeding, to make sure I'm not missing something.

[Jag96]

All platforms are now updated, we're good to start QA @mvtglobally!

[mvtglobally]

Starting QA

[mvtglobally]

Regression is done @Jag96 @roryabraham

Checking off #6905 as issue #7029 is closed
Checking off #5150 as #7030 is closed

Can I check off #6993 as #7032 is repro in PROD?

Issues reported
#7032
#7030
#7023
#7008

[francoisl]

Can I check off #6993 as #7032 is repro in PROD?

I can't reproduce the issue on staging nor production at the moment, but I might be doing something wrong, I'll try from another account. Either way yeah I think we can check it off, the issue is assigned to an engineer for triage.

[mvtglobally]

@francoisl checked off. #7032 is happening only with a brand new accounts.

Other than that, we should be good to deploy

[francoisl]

Got it, thanks! I'm going to check off the remaining Accesbility checkboxes and :shipit:

[francoisl]

[francoisl]

Deploy failed because of an issue that's being looked at here, we'll need to rerun this.

---

Edit: Fixed by #7044, which was CP'ed to staging.

[francoisl]