Update CONTRIBUTING.md #6887

mallenexpensify · 2021-12-22T23:30:47Z

Discussion here https://expensify.slack.com/archives/C01SKUP7QR0/p1640212812255600?thread_ts=1640200344.249400&cid=C01SKUP7QR0

Details

Adding more details about expected frequency of updates

Fixed Issues

Only text in CONTRIBUTING.md

Tests

Check to see https://github.com/Expensify/App/blob/main/CONTRIBUTING.md is updated.

QA Steps

Tested On

Screenshots

Web

Mobile Web

Desktop

iOS

Android

Discussion here https://expensify.slack.com/archives/C01SKUP7QR0/p1640212812255600?thread_ts=1640200344.249400&cid=C01SKUP7QR0

Beamanator · 2021-12-23T10:28:38Z

Suggested a few edits in slack :D

marcaaron · 2021-12-23T18:08:53Z

CONTRIBUTING.md

@@ -89,7 +89,7 @@ It’s possible that you found a bug or enhancement that we haven’t posted to
    ```
 9. [Open a pull request](https://docs.github.com/en/free-pro-team@latest/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork), and make sure to fill in the required fields.
 10. An Expensify engineer and a member from the Contributor-Plus team will be assigned to your pull request automatically to review.
-11. Provide daily updates until reaching completion of your PR.
+11. Daily updates on weekdays are expected. If there is a plan for no updates for a while we expect the courtesy to be informed about the duration there will be no work so that we may plan accordingly. Any issue without an update for 1 week with no explanation why there is no progress will be considered abandoned and will likely be closed or reassigned, and the original contract will be terminated.


Just pulling in that feedback from Alex B since I liked the phrasing and adding a few things for tone...

Daily updates on weekdays are highly recommended.

If you know you won’t be able to provide updates for > 1 week, please comment on the PR or issue how long you plan to be out so that we may plan accordingly. We understand everyone needs a little vacation here and there.

This could maybe be shortened

Any issue that doesn't receive an update after 1 week may be considered abandoned and the original contract terminated.

I think this phrasing is very clear:

Daily updates on weekdays are highly recommended. Any issue that doesn't receive an update after 1 week may be considered abandoned and the original contract terminated.

Love the shortened point 👍 I think it could be nice to touch up the phrase "Any issue that doesn't receive an update after 1 week may be considered abandoned..." - Something like this:

Any issue that doesn't receive an update for 1 full week may be considered abandoned...

Will you be updating the copy here @mallenexpensify or would you like one of us to update it?

Can one of you update the copy (if only cuz I'm not sure of the fastest/best way to do it :ohnothing:)

chiragsalian · 2021-12-29T20:08:41Z

Updated copy, ready for re-review.

Beamanator · 2021-12-30T07:40:40Z

CONTRIBUTING.md

@@ -89,7 +89,7 @@ It’s possible that you found a bug or enhancement that we haven’t posted to
    ```
 9. [Open a pull request](https://docs.github.com/en/free-pro-team@latest/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork), and make sure to fill in the required fields.
 10. An Expensify engineer and a member from the Contributor-Plus team will be assigned to your pull request automatically to review.
-11. Provide daily updates until reaching completion of your PR.
+11. Daily updates on weekdays are highly recommended. If you know you won’t be able to provide updates for > 1 week, please comment on the PR or issue how long you plan to be out so that we may plan accordingly. We understand everyone needs a little vacation here and there. Any issue that doesn't receive an update for 1 full week may be considered abandoned and the original contract terminated.


I could be wrong, but I thought @marcaaron 's comment here was suggesting we replace these two sentences:

If you know you won’t be able to provide updates for > 1 week, please comment on the PR or issue how long you plan to be out so that we may plan accordingly. We understand everyone needs a little vacation here and there.

With this 1 sentence:

Any issue that doesn't receive an update for 1 full week may be considered abandoned and the original contract terminated.

That being said, I'm pretty happy with the full text we have now 👍

His comment posted 3 new phrases compared to the earlier so I read it like so,
We can replace,

Daily updates on weekdays are expected.

with

Daily updates on weekdays are highly recommended.

Replace,

If there is a plan for no updates for a while we expect the courtesy to be informed about the duration there will be no work so that we may plan accordingly.

with,

If you know you won’t be able to provide updates for > 1 week, please comment on the PR or issue how long you plan to be out so that we may plan accordingly. We understand everyone needs a little vacation here and there.

Replace,

Any issue without an update for 1 week with no explanation why there is no progress will be considered abandoned and will likely be closed or reassigned, and the original contract will be terminated.

with,

Any issue that doesn't receive an update after 1 week may be considered abandoned and the original contract terminated.

So thats how i inferred it. We can wait for @marcaaron to confirm as well too but if we update it such the point is only,

Any issue that doesn't receive an update after 1 week may be considered abandoned and the original contract terminated.

then i feel like it doesn't capture this point which i feel is important,

If you know you won’t be able to provide updates for > 1 week, please comment on the PR or issue how long you plan to be out so that we may plan accordingly. We understand everyone needs a little vacation here and there.

I like where this landed. Nice edits @chiragsalian!

marcaaron · 2021-12-30T19:24:44Z

CONTRIBUTING.md

@@ -89,7 +89,7 @@ It’s possible that you found a bug or enhancement that we haven’t posted to
    ```
 9. [Open a pull request](https://docs.github.com/en/free-pro-team@latest/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork), and make sure to fill in the required fields.
 10. An Expensify engineer and a member from the Contributor-Plus team will be assigned to your pull request automatically to review.
-11. Provide daily updates until reaching completion of your PR.
+11. Daily updates on weekdays are highly recommended. If you know you won’t be able to provide updates for > 1 week, please comment on the PR or issue how long you plan to be out so that we may plan accordingly. We understand everyone needs a little vacation here and there. Any issue that doesn't receive an update for 1 full week may be considered abandoned and the original contract terminated.


I like where this landed. Nice edits @chiragsalian!

OSBotify · 2021-12-30T19:25:43Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2022-01-04T01:53:47Z

🚀 Deployed to staging by @marcaaron in version: 1.1.24-19 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	failure ❌

OSBotify · 2022-01-04T02:40:45Z

🚀 Deployed to production by @francoisl in version: 1.1.24-19 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	failure ❌

Update CONTRIBUTING.md

3860759

Discussion here https://expensify.slack.com/archives/C01SKUP7QR0/p1640212812255600?thread_ts=1640200344.249400&cid=C01SKUP7QR0

mallenexpensify requested a review from a team as a code owner December 22, 2021 23:30

mallenexpensify self-assigned this Dec 22, 2021

MelvinBot requested review from neil-marcellini and removed request for a team December 22, 2021 23:31

marcaaron requested review from Beamanator, chiragsalian and marcaaron December 23, 2021 18:01

marcaaron reviewed Dec 23, 2021

View reviewed changes

chiragsalian self-assigned this Dec 29, 2021

chiragsalian added 2 commits December 29, 2021 11:50

Merge branch 'main' into mallenexpensify-patch-1

d14a374

copy update

adcac91

chiragsalian requested a review from marcaaron December 29, 2021 20:08

Beamanator approved these changes Dec 30, 2021

View reviewed changes

marcaaron approved these changes Dec 30, 2021

View reviewed changes

marcaaron merged commit 6cf4a72 into main Dec 30, 2021

marcaaron deleted the mallenexpensify-patch-1 branch December 30, 2021 19:24

OSBotify mentioned this pull request Jan 4, 2022

Deploy Checklist: New Expensify 2022-01-04 #7005

Closed

45 tasks

mallenexpensify mentioned this pull request Jan 4, 2022

Update guidelines on bugs not happening in production #6895

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update CONTRIBUTING.md #6887

Update CONTRIBUTING.md #6887

mallenexpensify commented Dec 22, 2021

Beamanator commented Dec 23, 2021

marcaaron Dec 23, 2021

neil-marcellini Dec 27, 2021

Beamanator Dec 28, 2021

chiragsalian Dec 29, 2021

mallenexpensify Dec 29, 2021

chiragsalian commented Dec 29, 2021

Beamanator Dec 30, 2021

chiragsalian Dec 30, 2021

marcaaron Dec 30, 2021

marcaaron Dec 30, 2021

OSBotify commented Dec 30, 2021

OSBotify commented Jan 4, 2022

OSBotify commented Jan 4, 2022

Update CONTRIBUTING.md #6887

Update CONTRIBUTING.md #6887

Conversation

mallenexpensify commented Dec 22, 2021

Details

Fixed Issues

Tests

QA Steps

Tested On

Screenshots

Web

Mobile Web

Desktop

iOS

Android

Beamanator commented Dec 23, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chiragsalian commented Dec 29, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OSBotify commented Dec 30, 2021

OSBotify commented Jan 4, 2022

OSBotify commented Jan 4, 2022