Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update guidelines on bugs not happening in production #6895

Merged
merged 2 commits into from
Dec 30, 2021
Merged

Update guidelines on bugs not happening in production #6895

merged 2 commits into from
Dec 30, 2021

Conversation

iwiznia
Copy link
Contributor

@iwiznia iwiznia commented Dec 23, 2021

Context https://expensify.slack.com/archives/C02NK2DQWUX/p1640209639081000

This is just a process change, no need to QA or test.

@iwiznia iwiznia self-assigned this Dec 23, 2021
@iwiznia iwiznia requested a review from a team as a code owner December 23, 2021 19:44
@MelvinBot MelvinBot requested review from danieldoglas and removed request for a team December 23, 2021 19:44
@iwiznia iwiznia changed the title Update guidelines on bugs not happening in production [HOLD] Update guidelines on bugs not happening in production Dec 23, 2021
@mallenexpensify
Copy link
Contributor

@iwiznia . Line 49

and add the DeployBlockerCash label.

I don't think contributors are able to add labels in issues, so we likely want to update this, maybe to "leave a comment in the issue - "This might be a deploy blocker"" (or.. similar)

@iwiznia iwiznia changed the title [HOLD] Update guidelines on bugs not happening in production Update guidelines on bugs not happening in production Dec 27, 2021
@iwiznia
Copy link
Contributor Author

iwiznia commented Dec 30, 2021

Bump @danieldoglas

danieldoglas
danieldoglas approved these changes Dec 30, 2021
View reviewed changes
Copy link
Contributor

@danieldoglas danieldoglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danieldoglas danieldoglas merged commit 3c4558d into main Dec 30, 2021
@danieldoglas danieldoglas deleted the iwiznia-patch-1-1 branch December 30, 2021 19:54
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Jan 4, 2022

🚀 Deployed to staging by @danieldoglas in version: 1.1.24-19 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 failure ❌

@OSBotify OSBotify mentioned this pull request Jan 4, 2022
Closed
45 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Jan 4, 2022

🚀 Deployed to production by @francoisl in version: 1.1.24-19 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 failure ❌

@mallenexpensify
Copy link
Contributor

mallenexpensify commented Jan 4, 2022 •
edited
Loading

@iwiznia can you drop a comment in #expensify-open-source that includes details on this update and also include this update too? #6968 (comment)
Also.. this one so we can keep them all together?!?
#6887

@iwiznia
Copy link
Contributor Author

iwiznia commented Jan 4, 2022

I think it is not needed, GH shows to every contributor that the file was updated and tells you to check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldoglas danieldoglas danieldoglas approved these changes

Assignees

@iwiznia iwiznia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iwiznia @mallenexpensify @OSBotify @danieldoglas