Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2022-01-25] Android/Chrome - Double keyboard appears after Split/ Request Money #7023

Closed
kbecciv opened this issue Jan 4, 2022 · 15 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Jan 4, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to https://staging.new.expensify.com
  2. Log in with any account
  3. Tap on Green Plus button
  4. Tap on Split/Request money

Expected Result:

User should have one keyboard after Split/ Request Money

Actual Result:

Double keyboard appears after Split/ Request Money

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • mWeb (Android/Chrome)

Version Number: 1.1.24-8

Reproducible in staging?: Yes

Reproducible in production?: Yes

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

@MelvinBot
Copy link

Triggered auto assignment to @marcochavezf (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@akshayasalvi
Copy link
Contributor

Related to my PR. #6285 Checking.

@marcochavezf
Copy link
Contributor

I was able to reproduce this issue in mWeb. I'm going to label it as External and Weekly because it's only happening in mWeb and not in the mobile app (at least on Android).

@marcochavezf marcochavezf added Weekly KSv2 and removed Daily KSv2 labels Jan 7, 2022
@marcochavezf marcochavezf removed their assignment Jan 7, 2022
@marcochavezf marcochavezf added the External Added to denote the issue can be worked on by a contributor label Jan 7, 2022
@MelvinBot
Copy link

Triggered auto assignment to @adelekennedy (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@MelvinBot MelvinBot added Daily KSv2 and removed Weekly KSv2 labels Jan 7, 2022
@parasharrajat
Copy link
Member

parasharrajat commented Jan 7, 2022

Proposal

  1. Use Textinput.setnativeProps to set the inputMode:none instead of directly passing the inputMode prop.inputMode is not a valid prop instead, a browser attribute. Thus we have to manually set it on the
    <TextInputAutoWidth
    .

We will have to create a .web.js variant which sets the inputMode attribute otherwise native will crash.

@botify botify removed the Daily KSv2 label Jan 8, 2022
@MelvinBot MelvinBot added the Weekly KSv2 label Jan 8, 2022
@MelvinBot
Copy link

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

@MelvinBot MelvinBot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 8, 2022
@MelvinBot
Copy link

Triggered auto assignment to @chiragsalian (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@adelekennedy
Copy link

@chiragsalian and @parasharrajat opened the job for proposals, I see @parasharrajat you already have a potential solution 🎉

@chiragsalian
Copy link
Contributor

The proposal looks good to me. Go ahead and create the PR @parasharrajat.

@adelekennedy
Copy link

@parasharrajat hiring you for the job!

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@botify botify added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jan 18, 2022
@botify
Copy link

botify commented Jan 18, 2022

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.30-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2022-01-25. 🎊

@botify botify changed the title Android/Chrome - Double keyboard appears after Split/ Request Money [HOLD for payment 2022-01-25] Android/Chrome - Double keyboard appears after Split/ Request Money Jan 18, 2022
@mvtglobally
Copy link

Issue not reproducible during KI retests. (Second week)

@adelekennedy
Copy link

closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2
Projects
None yet
Development

No branches or pull requests

9 participants