Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Removed \n for different copies of change password #6954

Merged
merged 1 commit into from
Dec 30, 2021
Merged

fix: Removed \n for different copies of change password #6954

merged 1 commit into from
Dec 30, 2021

Conversation

mananjadhav
Copy link
Collaborator

@mananjadhav mananjadhav commented Dec 30, 2021 •
edited
Loading

Details

  • Removed \n for different copies of change password

Fixed Issues

$ #6922

Tests

  • Tested for copies on different platforms
  • Tested for Spanish translations as well

QA Steps

  1. Click on the Profile picture to load settings
  2. Go to Security -> Change Password
  3. The copy in subtitle and the new password hint should be as a single sentence.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web-password-copy

web-spanish-password-copy

Mobile Web

mweb-password-copy

Desktop

desktop-password-copy

iOS

ios-password-copy

Android

android-password-copy

@mananjadhav mananjadhav requested a review from a team as a code owner December 30, 2021 16:29
@MelvinBot MelvinBot requested review from luacmartins and parasharrajat and removed request for a team December 30, 2021 16:29
parasharrajat
parasharrajat approved these changes Dec 30, 2021
View reviewed changes
Copy link
Member

@parasharrajat parasharrajat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

luacmartins
luacmartins approved these changes Dec 30, 2021
View reviewed changes
Copy link
Contributor

@luacmartins luacmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix!

@luacmartins luacmartins merged commit fd08d9d into Expensify:main Dec 30, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Jan 4, 2022

🚀 Deployed to staging by @luacmartins in version: 1.1.24-19 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 failure ❌

@botify botify mentioned this pull request Jan 4, 2022
Closed
@OSBotify OSBotify mentioned this pull request Jan 4, 2022
Closed
45 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Jan 4, 2022

🚀 Deployed to production by @francoisl in version: 1.1.24-19 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luacmartins luacmartins luacmartins approved these changes

@parasharrajat parasharrajat parasharrajat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mananjadhav @OSBotify @luacmartins @parasharrajat