-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the current password field also submittable via Enter #6904
Conversation
Sorry @nickmurray47, this should have been draft PR at this point. |
@nickmurray47 This is ready for a review. It is a simple change and it is same as on the other password field in the form: https://github.com/Expensify/App/pull/6904/files#diff-b4474bebdf5744f78c9eded74e6bd3e4d2723040f750e573f4ef4bddfe00481bL189. I have tested it the other day, but unfortunately I did not make screenshots or video, but I believe this is such a simple change it is not required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @nickmurray47 in version: 1.1.24-19 🚀
|
🚀 Deployed to production by @francoisl in version: 1.1.24-19 🚀
|
Details
A very small UI change which makes the
Current password
field actionable viaEnter
.On the form to change password, this change would enable user to submit the form using
Enter
key also when theCurrent password
field would be focused. This is for scenario, when user enters both, current and new password, but realizes they entered the current password wrong, then they can submit the form while focusing the current password too.If the New password is not filled in, validation does not pass.
Fixed Issues
$ #6823
Tests
Change password page
QA Steps
Change password page
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android