[HOLD for payment 2022-01-11] Submitting the change password form on PasswordPage via the enter doesn’t do anything - Reported By: @anthony-hull

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to app
2. Login
3. Go to Profile setting > Security > Update password
4. Fill all the data fill in all the data

EDIT
5. Focus on the current password field and press enter.

Expected Result:

User should be able to save when hitting Enter on keyboard

EDIT
The form should be submitted even if the current password was focused.

Actual Result:

Nothing happens

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• Desktop App

Version Number: 1.1.22-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @anthony-hull
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1639676546346400

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @sketchydroide (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[anthony-hull]

App/src/pages/settings/PasswordPage.js

Lines 218 to 228 in d012bea

	<ExpensiTextInput
	label={`${this.props.translate('passwordPage.confirmNewPassword')}*`}
	secureTextEntry
	autoCompleteType="password"
	textContentType="password"
	value={this.state.confirmNewPassword}
	onChangeText={text => this.clearErrorAndSetValue('confirmNewPassword', text, ['confirmPasswordMatch'])}
	hasError={this.state.errors.confirmNewPassword || this.state.errors.confirmPasswordMatch}
	errorText={this.getErrorText(this.state.errors.confirmNewPassword ? 'confirmNewPassword' : 'confirmPasswordMatch')}
	onSubmitEditing={this.validateAndSubmitForm}
	/>

this.validateAndSubmitForm isn't defined.
I propose to change this to use this.submit as used by the button.

[sketchydroide]

This is a bug, and I also think this is an external

[MelvinBot]

Triggered auto assignment to @MitchExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[sketchydroide]

I think this will be waiting for people to return from Christmas ooo

[MitchExpensify]

Upwork Job

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

[MelvinBot]

Triggered auto assignment to @mountiny (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[mountiny]

@anthony-hull This has already been fixed in your PR here. I could not see in the PR comment, neither in the issue, that you would bring this issue and fix up. For future, please, consider bringing this up also with the engineer working on the issue with you. Especially if it is so closely related change. I am sure we can amend the compensation accordingly for you noticing it.

Of course, if the bug is unrelated to what you work on and the fix would be more complicated, your process is the correct one.

I will go ahead and update the PR to link it to this issue, since it also fixed this and assign you. Please, apply for the upwork job for reporting and fixing this issue.

cc @MitchExpensify

[MelvinBot]

📣 @anthony-hull You have been assigned to this job by @mountiny!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mountiny]

@MitchExpensify I would propose to also make the first Current password field submittable via enter. In instance where user fills in the new password first and then comes back to the current one, or realizes they made a mistake in the current one after filling in the new one, they can still submit via Enter. I think that in this case, where there are only 2 fields in the form, it is better UX. What do you think? I could submit this fix if you agree too!

[anthony-hull]

I think that is sensible. We should add that in.

Thanks for the advice for future issues I come across like this, I prefer that idea. It's much less admin overhead for us all to do it like that 😀

[mountiny]

@anthony-hull Thank you for understanding. I will wait for Mitch to see what he thinks too. Also @parasharrajat and @sketchydroide if you have time! Thank you!

[anthony-hull]

Upwork Job

@MitchExpensify this URL is to a job with an unrelated title :)

[parasharrajat]

Hmm. @mountiny I would not say that it adds a lot of value but I agree that we can do that it does not hurt in any way.

[mountiny]

@parasharrajat I agree it won't add much value, but it will in my opinion improve UX slightly, so it might be worth it since the change is one line.

[MitchExpensify]

@MitchExpensify this URL is to a job with an unrelated title :)

Ooops @anthony-hull - Thanks, fixed!

[MitchExpensify]

@MitchExpensify I would propose to also make the first Current password field submittable via enter. In instance where user fills in the new password first and then comes back to the current one, or realizes they made a mistake in the current one after filling in the new one, they can still submit via Enter. I think that in this case, where there are only 2 fields in the form, it is better UX. What do you think? I could submit this fix if you agree too!

This makes sense to me @mountiny !

[mountiny]

Perfect! I will take the PR out of Draft and ask for a review.

[botify]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.24-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Anthony remove second secure inputs #6809

If no regressions arise, payment will be issued on 2022-01-11. 🎊

[MitchExpensify]

Offer sent on the Upwork job, once accepted I'll pay with reporting bonus @anthony-hull - Thanks!

[parasharrajat]

@MitchExpensify Can I apply for C+ to the same job?

[mallenexpensify]

@parasharrajat It looks like the Upwork job is closed so @MitchExpensify will need to create a new job to pay you (which can be done now or later)

[MitchExpensify]

Invite sent for the new job here @parasharrajat !

[MitchExpensify]

Paid with reporting bonus @anthony-hull, thanks again

[MitchExpensify]

Paid @parasharrajat ! Thank you

[parasharrajat]

@MitchExpensify you are yet to release the payment. I have only accepted the offer so far for job.

[MitchExpensify]

Weird. Thought it went through - Definitely paid now! Thanks for the heads up @parasharrajat