Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change tooltiptext of avatar in LHN to Settings #6976

Merged
merged 1 commit into from
Jan 3, 2022

Conversation

sobitneupane
Copy link
Contributor

Details

Change the tooltiptext of avatar from displayName to Settings
This issue is occurring in web and desktop app. I have tested only for web. So, I would like to request reviewer to double check in desktop.

Fixed Issues

$ #6911

Tests

  1. Hovered on avatar near to the search icon at the top of LHN

QA Steps

  1. Open app in desktop or Open web app
  2. Hover on avatar near to the search icon at the top of LHN

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screenshot from 2022-01-02 14-05-07

Mobile Web

Desktop

iOS

Android

@sobitneupane sobitneupane requested a review from a team as a code owner January 2, 2022 10:27
@MelvinBot MelvinBot requested review from Beamanator and parasharrajat and removed request for a team January 2, 2022 10:27
@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@sobitneupane
Copy link
Contributor Author

sobitneupane commented Jan 2, 2022

I have read the CLA Document and I hereby sign the CLA

Copy link
Member

@parasharrajat parasharrajat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I am not asking for the remaining screenshots as this is a minor change and I know it will work.

cc: @Beamanator
🎀 👀 🎀 C+ reviewed

@Beamanator
Copy link
Contributor

Beamanator commented Jan 3, 2022

I just approved & ran the GH workflows, I assume tests will pass 👍

Copy link
Contributor

@Beamanator Beamanator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 💪 Will merge once tests pass

@Beamanator Beamanator merged commit a87b53c into Expensify:main Jan 3, 2022
@OSBotify
Copy link
Contributor

OSBotify commented Jan 3, 2022

@sobitneupane, Great job getting your first Expensify/App pull request over the finish line! 🎉

I know there's a lot of information in our contributing guidelines, so here are some points to take note of 📝:

  1. Now that your first PR has been merged, you can be hired for another issue. Once you've completed a few issues, you may be eligible to work on more than one job at a time.
  2. Once your PR is deployed to our staging servers, it will undergo quality assurance (QA) testing. If we find that it doesn't work as expected or causes a regression, you'll be responsible for fixing it. Typically, we would revert this PR and give you another chance to create a similar PR without causing a regression.
  3. Once your PR is deployed to production, we start a 7-day timer ⏰. After it has been on production for 7 days without causing any regressions, then we pay out the Upwork job. 💰

So it might take a while before you're paid for your work, but we typically post multiple new jobs every day, so there's plenty of opportunity. I hope you've had a positive experience contributing to this repo! 😊

@OSBotify
Copy link
Contributor

OSBotify commented Jan 3, 2022

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Jan 4, 2022

🚀 Deployed to staging by @Beamanator in version: 1.1.24-19 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 failure ❌

@OSBotify
Copy link
Contributor

OSBotify commented Jan 4, 2022

🚀 Deployed to production by @francoisl in version: 1.1.24-19 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants