-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change tooltiptext of avatar in LHN to Settings #6976
Change tooltiptext of avatar in LHN to Settings #6976
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I am not asking for the remaining screenshots as this is a minor change and I know it will work.
cc: @Beamanator
🎀 👀 🎀 C+ reviewed
I just approved & ran the GH workflows, I assume tests will pass 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 💪 Will merge once tests pass
@sobitneupane, Great job getting your first Expensify/App pull request over the finish line! 🎉 I know there's a lot of information in our contributing guidelines, so here are some points to take note of 📝:
So it might take a while before you're paid for your work, but we typically post multiple new jobs every day, so there's plenty of opportunity. I hope you've had a positive experience contributing to this repo! 😊 |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @Beamanator in version: 1.1.24-19 🚀
|
🚀 Deployed to production by @francoisl in version: 1.1.24-19 🚀
|
Details
Change the tooltiptext of avatar from displayName to Settings
This issue is occurring in web and desktop app. I have tested only for web. So, I would like to request reviewer to double check in desktop.
Fixed Issues
$ #6911
Tests
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android