[HOLD for payment 2022-01-11] Tooltip above your own avatar in the LHN does not say “settings”

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open app
2. Login
3. Hover over the your own avatar in the LHN

Expected Result:

Tooltip above your own avatar in the LHN would say “settings” instead of my name, since clicking on it opens the settings modal.

Actual Result:

Tooltip above your own avatar in the LHN does not say “settings”.

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• Desktop App

Version Number: 1.1.23-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1640640138138800

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @francoisl (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MelvinBot]

Triggered auto assignment to @Christinadobrzyn (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[sobitneupane]

Proposal:
Changing tooltipText to {this.props.translate('common.settings')} in AvatarWithIndicator component in SidebarLink.js solves the issue.

<AvatarWithIndicator
                            source={this.props.myPersonalDetails.avatar}
                            isActive={this.props.network && !this.props.network.isOffline}
                            isSyncing={this.props.network && !this.props.network.isOffline && this.props.isSyncingData}
                            tooltipText={this.props.translate('common.settings')} // <--- Changed Line
                        />

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

[MelvinBot]

Triggered auto assignment to @Beamanator (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[mallenexpensify]

Job posted https://www.upwork.com/jobs/~01703ed57efa762976
@parasharrajat can you review @sobitneupane 's proposal above? #6911 (comment)

[parasharrajat]

@sobitneupane 's proposal looks good.

cc: @Beamanator
🎀 👀 🎀 C+ reviewed

[Beamanator]

Agreed, hiring @sobitneupane !

[MelvinBot]

📣 @sobitneupane You have been assigned to this job by @Beamanator!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[sobitneupane]

Thanks. I have applied for the job. The PR will be ready for review by 2nd January 2022.

[Beamanator]

Thanks @sobitneupane 👍 Just so you know, some Expensify employees are on vacation due to the holiday season so if you experience any delays, feel free to ping us here :)

[sobitneupane]

Sure. Thank You.

[mallenexpensify]

Hired @sobitneupane in Upwork!

[botify]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.24-19 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Change tooltiptext of avatar in LHN to Settings #6976

If no regressions arise, payment will be issued on 2022-01-11. 🎊

[Christinadobrzyn]

I believe we have regressions for this PR, @Beamanator @parasharrajat Is that true or can this be paid?

[Beamanator]

Those scary looking failure ❌ messages just mean that the entire production deploy with all of the PRs that we tried to make live crashed - Looking at the PR that fixed this issue (#6976), I don't see an comments saying there were regressions nor do I see any PRs linked to it after it was merged, so I would say we're good to go!

[Christinadobrzyn]

Thanks for confirming @Beamanator - Paid @sobitneupane in Upwork

Invited @parasharrajat so I can pay you as the Contributor +!

[Christinadobrzyn]

Paid @parasharrajat for C+. Closing!