fix: room page layout #6951
Merged
fix: room page layout #6951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @aldo-expensify |
|
Testing... |
aldo-expensify
approved these changes
Dec 30, 2021
|
|
|
Will merge after tests pass |
|
Thanks for the screenshots. |
OSBotify
pushed a commit
that referenced
this pull request
Dec 30, 2021
fix: room page layout (cherry picked from commit e787423)
|
FYI I am fixing a bug with the cherry pick GitHub action that we found via this PR. Once we fix it we will retry this cherry pick. |
This was referenced Dec 30, 2021
OSBotify
pushed a commit
that referenced
this pull request
Dec 30, 2021
fix: room page layout (cherry picked from commit e787423)
AndrewGable
added a commit
that referenced
this pull request
Dec 30, 2021
…ng-6951 🍒 Cherry pick PR #6951 to staging 🍒
|
We are still seeing issue on mWeb Safari. Did the steps mean to say "We CAN'T fix it for mWeb Safari" ? RPReplay_Final1640914353.MP4Image.from.iOS.6.MP4 |
|
Sorry, mistyping. Yes, we can't fix on mobile safari @mvtglobally. |
|
🚀 Deployed to staging by @aldo-expensify in version: 1.1.24-19 🚀
|
45 tasks
|
🚀 Deployed to production by @francoisl in version: 1.1.24-19 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$ #6929
Tests | QA Steps
Tested On
Screenshots
Web | Desktop
Mobile Web
iOS
Android