Deploy Checklist: Expensify.cash 2021-07-28

[OSBotify]

Release Version: 1.0.81-4
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Add offline message to IOU and Split bill and allow currency selection while offline #4019
• [No QA] Add test for matching Translations keys #4090
• [CP Staging] Remove duplicate form fields #4117
• 🍒 Cherry pick PR #4117 to staging 🍒 #4125
• fix: paste and Ctrl+z #4131
• 3770 multi language improvements #4134
• Modify line height so text does not get cut off in LHN #4143
• 🍒 Cherry pick PR #4131 to staging 🍒 #4149
• Refactor withLocalize + fix displayName #4150
• 🍒 Cherry pick PR #4143 to staging 🍒 #4152
• Fix copy to clipboard in long emails #4154
• Fix keyboard shortcut #4159
• Adjust outline for focused elments #4170
• [IS-3599] Fixed crash issue when editing a message #4172
• Fix validation messages hidden behind keyboard #4174
• Fix: Enable default context-menu on messages being edited #4179
• Fix link to AsyncStorage documentation #4182
• [No QA] Use Hermes on iOS #4183
• [No QA] fix: bash escaping in deployBlocker.yml #4186
• Fix: Using trim() for better UX #4190
• 🍒 Cherry pick PR #4019 to staging 🍒 #4193
• Context-menu repositioned #4194
• Update version to 1.0.79-5 on staging #4197
• Update version to 1.0.79-6 on staging #4202
• Update version to 1.0.80-0 on staging #4204
• Beta race fixes #4205
• Correct emoji presentation on emoji picker #4206
• Added Balance badge to the Settings page #4220
• [NO QA] Add Daily label to issue templates #4224
• Fetch local currency on each IOU request, to ensure local currency is always up to date #4225
• Remove Bintray repository to speed up Android builds #4227
• Fix Keyboard input for workspace invite page on mobile keyboards #4228
• Allow messages scrolling within edit box. #4230
• Make sure we get state/status from the right variable name when we get chat report name #4239
• Show day of the week when other user is in a different date #4240
• Revert add payment button changes #4242
• Web - Settings - Dropdown symbol overlaps with text in the box #4243
• 🍒 Cherry pick PR #4243 to staging 🍒 #4245
• Add more Firebase performance tracing. Improve Android boot time. #4247
• 🍒 Cherry pick PR #4239 to staging 🍒 #4249
• Remove (NEW!) message after logout and update it to be unread count #4250
• Do not use a company address for a personal requestor #4251
• Style fix #4257
• Add beta check to Workspaces page #4259
• Fix bolded text for Existing Owners Error #4261
• Prevent accounts without account numbers from breaking the payments page #4262
• IOU - Autofocus 'What's it for?' text box in details page #4263
• Update CONTRIBUTING.md #4265
• Prevent large attachment #4269
• Disable the submit button if required form fields are not filled out #4272
• Use proper width for Cancel/Decline Button Text #4275
• Update version to 1.0.80-3 on staging #4278
• Update version to 1.0.81-0 on staging #4282
• fix styling for report typing and timezone indicators #4285
• Fix staging due to undefined Onyx key #4286
• 🍒 Cherry pick PR #4286 to staging 🍒 #4289
• [No QA] Setup Flipper plugins when on native & dev #4290
• Update Standard.md #4294
• chore(bumped-ecommon-ver): Updated expensify-common version #4295
• [No QA] Fix crash #4297
• Fix broken list components on staging #4300
• [No QA] Update company address label text #4301
• Fix rendering of timezone info inside chats when the selected language is Spanish #4309
• Reduce debounce time to 75ms when filtering search. #4311
• Update Onyx version to improve handling of defaultKeyStates #4312
• Different throw for Missing partnerUserSecret #4313
• [No QA] Fix Flipper for Android #4317
• Send emailList as string when removing from workspace #4318
• Patch for PR #4190  #4322

Deploy Blockers:

• Infinite loading when logging in  #4284
• App is crashing when loading contacts / user list  #4293

cc @Expensify/applauseleads

[isagoico]

Starting QA 🚀

[isagoico]

Checking off these PRs that were added to the list because of the Cherry pick bug:

1. Add offline message to IOU and Split bill and allow currency selection while offline #4019
2. [CP Staging] Remove duplicate form fields #4117
3. fix: paste and Ctrl+z #4131
4. Modify line height so text does not get cut off in LHN #4143
5. 🍒 Cherry pick PR #4131 to staging 🍒 #4149
6. 🍒 Cherry pick PR #4143 to staging 🍒 #4152
7. 🍒 Cherry pick PR #4019 to staging 🍒 #4193
8. 🍒 Cherry pick PR #4243 to staging 🍒 #4245
9. 🍒 Cherry pick PR #4239 to staging 🍒 #4249

[isagoico]

Regression is finished!
Issues found:

1. iOS - Sign in - Entering long e-mail address will break layout #4296
2. App is crashing when loading contacts / user list  #4293
3. Login - Entering incorrect and short password will return wrong error message  #4292
4. Unable to remove users/ user from the Workplace #4299

PRs are finished too
Comments added:

1. Fix: Using trim() for better UX #4190 (comment)
2. Show day of the week when other user is in a different date #4240 (comment)

• IOU - Autofocus 'What's it for?' text box in details page #4263 this PR is missing QA because is currently not testeable because of the crash App is crashing when loading contacts / user list  #4293

Internal QA

• Remove Bintray repository to speed up Android builds #4227 (CC @HorusGoul)

Thanks!

[isagoico]

#4293 just confirmed there was no crash 🎉 checking it off.

There was a bunch of blocked steps on our regression because of this issue 🔝. I would propose restarting QA by removing/readding the Lock label and proceed with a new QA run so we have a full regression and test new PRs OR we could just retest the blocked steps (that are a lot) only. What do you think @roryabraham @AndrewGable ?

Side note: Looks like the CP staging bug is back, these PRs are not in staging and need to be checked off/removed:

1. Adjust outline for focused elments #4170
2. Context-menu repositioned #4194
3. Added Balance badge to the Settings page #4220
4. Revert add payment button changes #4242
5. Fix bolded text for Existing Owners Error #4261
6. Prevent large attachment #4269
7. Use proper width for Cancel/Decline Button Text #4275
8. [No QA] Setup Flipper plugins when on native & dev #4290
9. [No QA] Fix crash #4297

[roryabraham]

Let's retest the blocked steps and do another full regression suite tomorrow. But there should be no need to remove and re-add the lock label, right? We don't need to potentially introduce more deploy blockers in this release 😅

[isagoico]

These 2 PRs had an issue are still failing:
#4190 (comment) (@johnmlee101)
#4240 (comment) (@Dal-Papa)

This internal QA need to be tested too: #4227 (@HorusGoul @Dal-Papa)

[isagoico]

#4263 was retested and was a pass 🎉

[Jag96]

Tested and checked off #4227, and just CP'd #4322 to staging so that should be good to re-test once it gets deployed. Will look into #4240 (comment) next.

[Jag96]

Checked off the following that were added by the CP bug:

• 4090
• 4172
• 4272
• 4285
• 4294
• 4295
• 4301
• 4309
• 4311
• 4312
• 4313
• 4317
• 4318
• 4322 (This was the fix for 4190)

[Jag96]

Looking at #4240 I can't reproduce the issue on staging on web:

Account 1	Account 2

@isagoico are you still seeing the issue on staging?

Edit: Ah nvm, looks like its only on mobile/desktop, will re-test

[isagoico]

#4190 (comment) checking it off 🎉

[Jag96]

Ok, tested on staging iOS and Desktop and it's working for me!

iOS	Desktop

For desktop, I had to go to staging.new.expensify.com/Expensify.cash.dmg to ensure I was on staging. @isagoico can you reproduce #4240 on staging still?

[isagoico]

@Jag96 asked a tester to check on their side, will update with the results

[isagoico]

It was a pass for the tester 🎉 checking it off.
This should be the last to check off the list, will go ahead with the prod deploy CC @roryabraham

[isagoico]