Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove (NEW!) message after logout and update it to be unread count #4250

Merged
merged 2 commits into from
Jul 28, 2021

Conversation

HorusGoul
Copy link
Contributor

Fixed Issues

$ #3971

Tests/QA Steps

  1. Open two Expensify accounts. Let's call them (a) and (b).
  2. Make (a) focus a conversation with an account that is not (b).
  3. From (b), send a message to (a).
  4. From (a), make sure the title is updated and is set to (1) Expensify.cash, and the favicon has the red dot.
  5. From (a), log out and once you're in the Sign In screen, make sure the title and the favicon have been set to their default values, no dot in the favicon, and the Expensify.cash title.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen.Recording.2021-07-27.at.10.57.59.mov

@HorusGoul HorusGoul requested a review from a team July 27, 2021 09:28
@HorusGoul HorusGoul self-assigned this Jul 27, 2021
@MelvinBot MelvinBot requested review from deetergp and removed request for a team July 27, 2021 09:28
Copy link
Contributor

@deetergp deetergp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and tests pass 👍

@deetergp deetergp merged commit a2888f7 into main Jul 28, 2021
@deetergp deetergp deleted the horus-remove-new-message-after-logout branch July 28, 2021 00:24
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.80-3🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.81-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants