Fix Keyboard input for workspace invite page on mobile keyboards #4228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomatoToaster
changed the title
|
Thanks for the PR @TomatoToaster . |
TomatoToaster
changed the title
|
Ok this is ready for review. I can't get workspaces to work on android emulator for some reason, but I think this will be easier to QA on android when this hits staging anyway. |
ctkochan22
approved these changes
Jul 26, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
This was referenced Jul 27, 2021
|
🚀 Deployed to staging in version: 1.0.80-3🚀
|
|
🚀 Deployed to production in version: 1.0.81-4🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ctkochan22, please review
cc: @parasharrajat
Details
Now we are allowing users to invite multiple emails at once. On iOS, since we have made this an email specific keyboard, we can't use commas to invite multiple users. This PR turns this input into a regular keyboard so users can do that.
Fixed Issues
resolves this regression identified: #4068 (comment)
Tests
Web QA tested locally on iOS emulator
QA Steps
Should be tested on iOS and android.
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Now (good):
Before (bad):
Android