Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix styling for report typing and timezone indicators #4285

Merged
merged 3 commits into from
Jul 30, 2021
Merged

fix styling for report typing and timezone indicators #4285

merged 3 commits into from
Jul 30, 2021

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Jul 28, 2021 •
edited
Loading

Details

  1. Reduced gap between chat list and composer.
  2. Removed boldness from the typing indicator & Timezone info.
  3. Added Wrapping to both of the above.

Fixed Issues

$ #3987

Tests | QA Steps

  1. Open NewDot on Device A.
  2. Open a chat with a user at a different timezone. Check the Timezone info.
  3. Type a message on Device B & and check the typing status on Device A.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web-com-gap
web-com

Mobile Web

com-m

Desktop

com-d

iOS

com-i

Android

com-a

@parasharrajat parasharrajat mentioned this pull request Jul 28, 2021
Closed
@parasharrajat parasharrajat marked this pull request as ready for review July 28, 2021 23:02
@parasharrajat parasharrajat requested a review from a team as a code owner July 28, 2021 23:02
@MelvinBot MelvinBot requested review from NikkiWines and removed request for a team July 28, 2021 23:02
NikkiWines
NikkiWines previously approved these changes Jul 29, 2021
View reviewed changes
Copy link
Contributor

@NikkiWines NikkiWines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :shipit:

@NikkiWines
Copy link
Contributor

Oh, except the conflicts. Sorry @parasharrajat

@parasharrajat
Copy link
Member Author

@NikkiWines All set.

@NikkiWines NikkiWines merged commit 7cd2869 into Expensify:main Jul 30, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

This was referenced Jul 30, 2021
Closed
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.81-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Aug 6, 2021

🚀 Deployed to production in version: 1.0.82-7🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikkiWines NikkiWines NikkiWines approved these changes

Assignees

@parasharrajat parasharrajat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parasharrajat @NikkiWines @OSBotify