Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust outline for focused elments #4170

Merged
merged 2 commits into from
Jul 29, 2021
Merged

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Jul 21, 2021

Details

Fixed Issues

$ Fixes #3959

Tests | QA Steps

  1. Open any convo on E.cash on the web.
  2. Try to use the tab for navigation.
  3. See multiple elements get focus with an outline that is different across the platforms. (please look at the original issue for Image Samples).

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Chrome

out-w-chrome

Firefox

out-w-firefox

Desktop

Linux desktop

out-d

MAC

out-d-mac

@parasharrajat parasharrajat marked this pull request as ready for review July 28, 2021 10:35
@parasharrajat parasharrajat requested a review from a team as a code owner July 28, 2021 10:35
@MelvinBot MelvinBot requested review from MonilBhavsar and removed request for a team July 28, 2021 10:36
@parasharrajat
Copy link
Member Author

@MonilBhavsar This is ready for review. Thanks.

@MonilBhavsar
Copy link
Contributor

Working well but outline is not visible in these two links.

Screenshot 2021-07-29 at 3 29 26 PM

@parasharrajat
Copy link
Member Author

@MonilBhavsar We decided to do that later in a separate issue #3959 (comment).

Even that link has an outline but it's not visible on blue background. We have to adjust different components with different outline styles.

@MonilBhavsar MonilBhavsar merged commit f99dea6 into Expensify:main Jul 29, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.81-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Aug 6, 2021

🚀 Deployed to production in version: 1.0.82-7🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@parasharrajat parasharrajat deleted the outline branch November 20, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make outline consistent for all focusable elements in the APP across platforms.
4 participants