Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite loading when logging in #4284

Closed
5 tasks done
isagoico opened this issue Jul 28, 2021 · 4 comments
Closed
5 tasks done

Infinite loading when logging in #4284

isagoico opened this issue Jul 28, 2021 · 4 comments
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@isagoico
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Log in to staging.new.expensify.com

Expected Result:

User should be able to log in.

Actual Result:

Infinite loading and a JS error is displayed.

Workaround:

Refreshing the page solves the issue.

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.0.81-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

image

Expensify/Expensify Issue URL:

View all open jobs on Upwork


From @marcaaron https://expensify.slack.com/archives/C01GTK53T8Q/p1627508142417800

Is it known that logging in is borked on staging or is this just for me?
It’s throwing on this line ->

@isagoico isagoico added DeployBlockerCash This issue or pull request should block deployment Engineering Daily KSv2 labels Jul 28, 2021
@MelvinBot
Copy link

Triggered auto assignment to @joelbettner (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@github-actions github-actions bot added Hourly KSv2 and removed Daily KSv2 labels Jul 28, 2021
@marcaaron marcaaron assigned marcaaron and unassigned joelbettner Jul 28, 2021
@marcaaron
Copy link
Contributor

Chatting with @luacmartins we think it was caused by this PR #4134 cc @iwiznia @madmax330

Sending the fix now.

@Jag96
Copy link
Contributor

Jag96 commented Jul 29, 2021

The fix has been CP'd to staging and this is no longer a deploy blocker, closing

@Jag96 Jag96 closed this as completed Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants