Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use a company address for a personal requestor #4251

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

Dal-Papa
Copy link

@Dal-Papa Dal-Papa commented Jul 27, 2021

Details

We were asking for a company address on a personal requestor. We are now asking for a regular address.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/171703

Tests

Since it is difficult to test for Web-Secure related features in App locally, I've decided to simply :

QA Steps

Same than test steps except it will be :

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen Shot 2021-07-27 at 11 24 56

Mobile Web

Screen Shot 2021-07-27 at 11 44 47

Desktop

iOS

Android

@Dal-Papa Dal-Papa self-assigned this Jul 27, 2021
@Dal-Papa Dal-Papa marked this pull request as ready for review July 27, 2021 09:53
@Dal-Papa Dal-Papa requested a review from a team as a code owner July 27, 2021 09:53
@MelvinBot MelvinBot requested review from MonilBhavsar and removed request for a team July 27, 2021 09:53
@Dal-Papa Dal-Papa changed the title Do not use a company address for a personal requestor [HOLD for copy] Do not use a company address for a personal requestor Jul 27, 2021
@Dal-Papa Dal-Papa changed the title [HOLD for copy] Do not use a company address for a personal requestor Do not use a company address for a personal requestor Jul 28, 2021
@Dal-Papa
Copy link
Author

Copy has been validated, good to review.

@MonilBhavsar MonilBhavsar merged commit ad77386 into main Jul 28, 2021
@MonilBhavsar MonilBhavsar deleted the clem-requestor-address branch July 28, 2021 07:16
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.80-3🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.81-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants