Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Setup Flipper plugins when on native & dev #4290

Merged
merged 1 commit into from
Jul 29, 2021
Merged

Conversation

marcaaron
Copy link
Contributor

@marcaaron marcaaron commented Jul 28, 2021

Details

This PR adds some Flipper plugins to dev. These are things I have used and have found useful. I'm not creating an issue as these plugins are opt-in developer efficiency tools. If you like them use them. If not, ignore them. If there are any questions about how to use them I will answer them and we can create SO posts if needed. It's all pretty self explanatory once you install Flipper and build the app.

I created an SO post here to describe how to setup Flipper -> https://stackoverflow.com/c/expensify/questions/10490/10491

Fixed Issues

$ No Issue

Tests

  1. Make sure the web side is unaffected by these changes
  2. Install Flipper -> https://fbflipper.com/
  3. Build the development version of the app
  4. Verify you are able to Flipper

QA Steps

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

React DevTools

2021-07-28_14-27-44
2021-07-28_14-27-40

AsyncStorage

2021-07-28_14-26-55

Native layout

2021-07-28_14-26-24

React Native bridge

2021-07-28_14-25-58

Network traffic

2021-07-28_14-25-44

JS Console

2021-07-28_14-23-42

Device Logs

2021-07-28_14-23-23

@marcaaron marcaaron self-assigned this Jul 28, 2021
@marcaaron marcaaron marked this pull request as ready for review July 29, 2021 00:22
@marcaaron marcaaron requested a review from a team as a code owner July 29, 2021 00:22
@MelvinBot MelvinBot requested review from Jag96 and removed request for a team July 29, 2021 00:22
Copy link
Contributor

@Jag96 Jag96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! LGTM, no issues on web/desktop either

@Jag96 Jag96 merged commit 91b780e into main Jul 29, 2021
@Jag96 Jag96 deleted the marcaaron-bridgeSpy branch July 29, 2021 04:28
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.81-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Aug 6, 2021

🚀 Deployed to production in version: 1.0.82-7🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants