Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport/dev no registration no emission #475

Merged

Conversation

distributedstatemachine
Copy link
Contributor

@distributedstatemachine distributedstatemachine commented May 25, 2024

Description

"Companion PR" to #474

Related Issue(s)

  • Closes #[issue number]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

camfairchild and others added 30 commits April 29, 2024 17:10
fix: reject registrations only after 3 times target
…ion-limit

Revert "fix: reject registrations only after 3 times target"
hotfix: allow unstake below the min nom threshold when unstaking entire stake
fix finney deploy merge conflicts 5/20/2024
@distributedstatemachine
Copy link
Contributor Author

Merging even though e2e test failing , as the fix is on the commit-reveal branch @opentensor/nucleus

@distributedstatemachine distributedstatemachine merged commit 8b91ed4 into development May 29, 2024
10 of 11 checks passed
@distributedstatemachine distributedstatemachine deleted the backport/dev_no_registration_no_emission branch May 29, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants