Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reserved test nodes #406

Merged
merged 1 commit into from
May 10, 2024
Merged

Reserved test nodes #406

merged 1 commit into from
May 10, 2024

Conversation

shibshib
Copy link
Contributor

Description

This PR adds two flags to testnet nodes: reserved-nodes and reserved-only. These nodes serve to ensure that testnet nodes will only synchronize with the boot node, and no other nodes, this ensures that they won't lose their way if we have any issues with upgrades or bad blocks.

Type of Change

Additional flags

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@shibshib shibshib changed the base branch from development to main May 10, 2024 00:06
Copy link

@prop-opentensor prop-opentensor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@orriin orriin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

In the future we should figure out how to use badblocks for this instead.

@sam0x17 sam0x17 merged commit da21fb6 into main May 10, 2024
@sam0x17 sam0x17 deleted the reserved_test_nodes branch May 10, 2024 06:43
@sam0x17
Copy link
Contributor

sam0x17 commented May 10, 2024

I went a head and added this to development in #409

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants