Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong raw spec #460

Merged
merged 3 commits into from
May 23, 2024
Merged

Fix wrong raw spec #460

merged 3 commits into from
May 23, 2024

Conversation

open-junius
Copy link
Contributor

@open-junius open-junius commented May 23, 2024

Description

Fix the broken spec
Update all the node start commands in docs to align with polkadot 1.0

Related Issue(s)

  • Closes #[461]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@open-junius open-junius self-assigned this May 23, 2024
@open-junius open-junius added the blue team defensive programming, CI, etc label May 23, 2024
@open-junius
Copy link
Contributor Author

Confirmed with Liam, we can ignore the migration failure now.

@distributedstatemachine distributedstatemachine merged commit 571a409 into main May 23, 2024
7 checks passed
@distributedstatemachine distributedstatemachine deleted the junius/fix-wrong-raw-spec branch May 23, 2024 19:21
This was referenced May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blue team defensive programming, CI, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants