Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/no registration no emission #474

Merged
merged 7 commits into from
May 27, 2024

Conversation

distributedstatemachine
Copy link
Contributor

@distributedstatemachine distributedstatemachine commented May 25, 2024

Description

This PR burns emissions for subnets that has registration turned off

Related Issue(s)

  • Closes #[issue number]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@distributedstatemachine distributedstatemachine marked this pull request as draft May 25, 2024 17:29
@distributedstatemachine distributedstatemachine requested a review from a team May 25, 2024 17:42
Copy link
Contributor

@camfairchild camfairchild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than an extra test

pallets/subtensor/tests/block_step.rs Show resolved Hide resolved
@distributedstatemachine distributedstatemachine merged commit 40a8321 into main May 27, 2024
7 checks passed
@camfairchild camfairchild mentioned this pull request Jun 12, 2024
13 tasks
);

// drain the emission tuples for the subnet with registration on
SubtensorModule::drain_emission(next_block as u64);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is casting a function pointer to a u64, did you really mean to call next_block() here?

@distributedstatemachine distributedstatemachine deleted the hotfix/no_registration_no_emission branch June 23, 2024 13:15
@distributedstatemachine distributedstatemachine mentioned this pull request Jul 1, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants