Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/no reg emissions #602

Merged
merged 4 commits into from
Jul 1, 2024
Merged

Fix/no reg emissions #602

merged 4 commits into from
Jul 1, 2024

Conversation

distributedstatemachine
Copy link
Contributor

Description

When a subnet has a disabled registration during the epoch, we skip giving it emission. This was implemented in #474 but accidentally also skipped the epoch, making the incentive not update as we would expect. This fix emits 0 emission instead of exiting the epoch early.

Related Issue(s)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@distributedstatemachine distributedstatemachine added devnet-skip This PR will skip testing on devnet testnet-skip This PR will skip testing on testnet labels Jul 1, 2024
@distributedstatemachine distributedstatemachine merged commit 535983f into main Jul 1, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devnet-skip This PR will skip testing on devnet testnet-skip This PR will skip testing on testnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants