Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hotregs shib #379

Merged
merged 4 commits into from
Apr 30, 2024
Merged

Fix hotregs shib #379

merged 4 commits into from
Apr 30, 2024

Conversation

shibshib
Copy link
Contributor

@shibshib shibshib commented Apr 29, 2024

Description

This patch fix fixes the issue with registration interval being too short.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

No breaking change

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@shibshib shibshib changed the base branch from development to main April 29, 2024 23:36
@sam0x17 sam0x17 merged commit e2dd8c5 into main Apr 30, 2024
1 check passed
@distributedstatemachine distributedstatemachine deleted the fix_hotregs_shib branch April 30, 2024 08:58
@distributedstatemachine distributedstatemachine restored the fix_hotregs_shib branch May 23, 2024 12:13
@camfairchild camfairchild mentioned this pull request May 23, 2024
13 tasks
@distributedstatemachine distributedstatemachine deleted the fix_hotregs_shib branch June 23, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants