Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix finney deploy merge conflicts 5/20/2024 #442

Merged
merged 37 commits into from
May 21, 2024

Conversation

sam0x17
Copy link
Contributor

@sam0x17 sam0x17 commented May 20, 2024

reproduction steps:

git fetch && git checkout main && git pull origin main
git branch try-finney-deploy-5-20-2024
git checkout try-finney-deploy-5-20-2024
git merge origin/testnet

now at the merge conflict step, manually copy paste over the repo with the current files from testnet,

finally:

git add --all
git merge --continue

this gives us a clean merge commit that upgrades main to exactly what is currently on testnet, while preserving the commits, without messing up the state like the other merge methods were

keithtensor and others added 30 commits April 26, 2024 22:55
Fix migration order, comment on_runtime_upgrade
Add increase_take and decrease_take extrinsics, rate limiting, and tests
@sam0x17 sam0x17 self-assigned this May 20, 2024
@sam0x17 sam0x17 force-pushed the try-finney-deploy-5-20-2024 branch from 88cd41e to 1048858 Compare May 20, 2024 19:44
@sam0x17 sam0x17 requested a review from orriin May 20, 2024 20:57
@sam0x17 sam0x17 requested a review from a team May 21, 2024 19:17
@distributedstatemachine distributedstatemachine merged commit 65d8367 into main May 21, 2024
7 checks passed
@distributedstatemachine distributedstatemachine deleted the try-finney-deploy-5-20-2024 branch June 23, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants