Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix migration order, comment on_runtime_upgrade #372

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

gztensor
Copy link
Contributor

Description

This PR is primarily a fix for migration order. migrate_delete_subnet_21 and migrate_delete_subnet_3 update to respectively storage versions of 4 and 5, but the migrate_delete_subnet_3 migration is called first in on_runtime_upgrade, so migrate_delete_subnet_21 will never run.

Related Issue(s)

n/a

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

n/a

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

n/a

Additional Notes

n/a

@distributedstatemachine distributedstatemachine requested a review from a team April 29, 2024 05:37
@distributedstatemachine distributedstatemachine merged commit 002633d into development Apr 30, 2024
8 checks passed
@distributedstatemachine distributedstatemachine deleted the fix/migration_order branch April 30, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants