Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12.0.4 RC #7225

Merged
merged 1 commit into from
Nov 20, 2017
Merged

12.0.4 RC #7225

merged 1 commit into from
Nov 20, 2017

Conversation

MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Nov 20, 2017

We should get 12.0.4 out.

Waiting for:

Changelog:

Server

Others

@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Nov 20, 2017
@MorrisJobke MorrisJobke added this to the Nextcloud 12.0.4 milestone Nov 20, 2017
version.php Outdated

// The human readable string
$OC_VersionString = '12.0.3';
$OC_VersionString = '12.0.4 RC';
Copy link
Member

@nickvergessen nickvergessen Nov 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be RC1, just for consistancy?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure 👍

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@codecov
Copy link

codecov bot commented Nov 20, 2017

Codecov Report

Merging #7225 into stable12 will decrease coverage by <.01%.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             stable12    #7225      +/-   ##
==============================================
- Coverage       53.76%   53.76%   -0.01%     
  Complexity      22589    22589              
==============================================
  Files            1384     1384              
  Lines           86663    86663              
  Branches         1329     1329              
==============================================
- Hits            46596    46595       -1     
- Misses          40067    40068       +1
Impacted Files Coverage Δ Complexity Δ
version.php 0% <0%> (ø) 0 <0> (ø) ⬇️
lib/private/Security/CertificateManager.php 91.08% <0%> (-1%) 39% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php 72.28% <0%> (-0.25%) 136% <0%> (ø)
lib/private/Server.php 84.8% <0%> (+0.12%) 121% <0%> (ø) ⬇️

@rullzer rullzer merged commit b8d3577 into stable12 Nov 20, 2017
@rullzer rullzer deleted the 12.0.4RC-version branch November 20, 2017 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants