Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable12] Don't add a LIKE condition when it's not needed #6945

Merged
merged 1 commit into from
Oct 25, 2017
Merged

[stable12] Don't add a LIKE condition when it's not needed #6945

merged 1 commit into from
Oct 25, 2017

Conversation

MorrisJobke
Copy link
Member

Backport of #6633

Code looks good 👍

@tcitworld @MorrisJobke
Don't add a LIKE condition when it's not needed
8c56f93 
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Oct 24, 2017
@MorrisJobke MorrisJobke added this to the Nextcloud 12.0.4 milestone Oct 24, 2017
@MorrisJobke MorrisJobke mentioned this pull request Oct 24, 2017
Merged
@codecov
Copy link

codecov bot commented Oct 25, 2017 •
edited
Loading

Codecov Report

Merging #6945 into stable12 will decrease coverage by <.01%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##             stable12    #6945      +/-   ##
==============================================
- Coverage       53.76%   53.76%   -0.01%     
- Complexity      22577    22578       +1     
==============================================
  Files            1384     1384              
  Lines           86622    86623       +1     
  Branches         1329     1329              
==============================================
  Hits            46569    46569              
- Misses          40053    40054       +1
Impacted Files Coverage Δ Complexity Δ
apps/dav/lib/CardDAV/CardDavBackend.php 85.56% <100%> (+0.03%) 89 <0> (+1) ⬆️
lib/private/Files/Cache/Propagator.php 94.93% <0%> (-1.27%) 16% <0%> (ø)

ChristophWurst
ChristophWurst approved these changes Oct 25, 2017
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 25, 2017
@rullzer rullzer merged commit 27e8352 into stable12 Oct 25, 2017
@rullzer rullzer deleted the 12-6633 branch October 25, 2017 06:53
@MorrisJobke MorrisJobke mentioned this pull request Nov 20, 2017
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@tcitworld tcitworld tcitworld approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@georgehrke georgehrke Awaiting requested review from georgehrke

@blizzz blizzz Awaiting requested review from blizzz

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 12.0.4
Development

Successfully merging this pull request may close these issues.
4 participants
@MorrisJobke @ChristophWurst @tcitworld @rullzer