#6307 fix page title not changed (stable12)

[burned42]

Fixes #6307

Backport of #6869

With this changes the page title gets set when switching to file list and tag list.

@danxuliu here is the pull request to bring the bugfix also to stable12.

[codecov]

Codecov Report

Merging #6987 into stable12 will increase coverage by <.01%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##             stable12    #6987      +/-   ##
==============================================
+ Coverage       53.75%   53.75%   +<.01%     
  Complexity      22579    22579              
==============================================
  Files            1384     1384              
  Lines           86623    86624       +1     
  Branches         1329     1329              
==============================================
+ Hits            46568    46569       +1     
  Misses          40055    40055

Impacted Files	Coverage Δ	Complexity Δ
apps/systemtags/js/systemtagsfilelist.js	73.27% <100%> (+0.23%)	0 <0> (ø)	⬇️

[danxuliu]

Tested and works 👍

While reviewing this again I have noticed that the page title for the All files section was already working as expected without this patch (both in master and in stable12) due to the change introduced in #6683/#6689. However, as said in #6869 (comment), even if the call is redundant it makes the code more consistent with other file lists, so I am fine with merging this now and improving the overall file list code later.

[danxuliu]

Thanks again, @burned42 :-D

By the way, as you may know, "Fixes #issueNumber" makes GitHub automatically close the referenced issue when the pull request is merged. In #6869 I changed your original comment from "Fixes #6307" to "Fixes (on master) #6307" to break the parsing and ensure that merging that pull request would not automatically close #6307, because it was filled against Nextcloud 12 but the pull request was for master. However, this pull request is for stable12, so I have changed "Fixes (on stable12) #6307" to "Fixes #6307" to ensure that it automatically closes the issue ;-)

I have also added "Backport of #6869" to ease tracking of the pull requests between branches :-)

[danxuliu]

Please review @nextcloud/javascript :-)

[burned42]

@danxuliu Apparently I didn't know that GitHub will automatically close the issue based on some specific text in the pull request. But I did notice that you changed the text in the other pull request and that is why I wrote it like that here. But thanks for clarifying and making the according changes :)

[MorrisJobke]

Tested and works 👍