Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable12] Allow to close sidebar for text files #6525

Merged
merged 1 commit into from
Sep 20, 2017
Merged

Conversation

MorrisJobke
Copy link
Member

backport of #6499

Tested and works here 👍

* the close button was overlapped by the text preview and you could not close the sidebar then

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@codecov
Copy link

codecov bot commented Sep 15, 2017

Codecov Report

Merging #6525 into stable12 will decrease coverage by <.01%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             stable12    #6525      +/-   ##
==============================================
- Coverage       53.77%   53.77%   -0.01%     
  Complexity      22527    22527              
==============================================
  Files            1383     1383              
  Lines           86498    86498              
  Branches         1328     1328              
==============================================
- Hits            46517    46515       -2     
- Misses          39981    39983       +2
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Cache/Propagator.php 94.93% <0%> (-1.27%) 16% <0%> (ø)
lib/private/Security/CertificateManager.php 91.08% <0%> (-1%) 39% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php 72.28% <0%> (-0.25%) 136% <0%> (ø)
lib/private/Server.php 84.8% <0%> (+0.12%) 121% <0%> (ø) ⬇️

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 18, 2017
@nickvergessen
Copy link
Member

Works, however if the text in the first line is long, the X will overlay the text and is not discoverable anymore.
bildschirmfoto vom 2017-09-18 13-25-50

@MorrisJobke MorrisJobke merged commit aa58633 into stable12 Sep 20, 2017
@MorrisJobke MorrisJobke deleted the 12-6499 branch September 20, 2017 14:06
@MorrisJobke MorrisJobke mentioned this pull request Nov 20, 2017
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants