Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use fopen directly when reading objects from s3 #7079

Merged
merged 1 commit into from
Nov 6, 2017
Merged

use fopen directly when reading objects from s3 #7079

merged 1 commit into from
Nov 6, 2017

Conversation

schiessle
Copy link
Member

@icewind1991 @schiessle
use fopen directly when reading objects from s3
1ed9a25 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@schiessle schiessle added the 3. to review Waiting for reviews label Nov 6, 2017
@schiessle schiessle added this to the Nextcloud 12.0.4 milestone Nov 6, 2017
@schiessle schiessle added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Nov 6, 2017
MorrisJobke
MorrisJobke approved these changes Nov 6, 2017
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 6, 2017
@MorrisJobke
Copy link
Member

CI failure unrelated. :/

@MorrisJobke MorrisJobke merged commit f9e29d0 into stable12 Nov 6, 2017
@MorrisJobke MorrisJobke deleted the s3-read-object-fopen-stable12 branch November 6, 2017 14:26
@MorrisJobke MorrisJobke mentioned this pull request Nov 20, 2017
Merged
1 task
@MorrisJobke MorrisJobke mentioned this pull request Dec 19, 2017
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 12.0.4
Development

Successfully merging this pull request may close these issues.
4 participants
@schiessle @MorrisJobke @rullzer @icewind1991