Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12] Update aws sdk + s3 improvements #6737

Merged
merged 16 commits into from
Oct 9, 2017
Merged

[12] Update aws sdk + s3 improvements #6737

merged 16 commits into from
Oct 9, 2017

Conversation

icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Oct 3, 2017

Backport of #4410 and #6602

Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Oct 3, 2017
@icewind1991 icewind1991 added this to the Nextcloud 12.0.4 milestone Oct 3, 2017
@mention-bot
Copy link

@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Xenopathic to be a potential reviewer.

Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
@codecov
Copy link

codecov bot commented Oct 9, 2017

Codecov Report

Merging #6737 into stable12 will decrease coverage by 0.01%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             stable12    #6737      +/-   ##
==============================================
- Coverage       53.78%   53.76%   -0.02%     
+ Complexity      22559    22554       -5     
==============================================
  Files            1383     1384       +1     
  Lines           86586    86546      -40     
  Branches         1328     1328              
==============================================
- Hits            46566    46531      -35     
+ Misses          40020    40015       -5
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/ObjectStore/S3.php 50% <0%> (-23.69%) 2% <0%> (-3%)
lib/private/RichObjectStrings/Validator.php 78.26% <0%> (-3.89%) 13% <0%> (ø)
lib/private/Group/Group.php 87.23% <0%> (-1.66%) 35% <0%> (-17%)
lib/private/legacy/template/functions.php 7.14% <0%> (ø) 0% <0%> (ø) ⬇️
...te/Authentication/LoginCredentials/Credentials.php 100% <0%> (ø) 2% <0%> (-2%) ⬇️
...s/files_external/lib/Lib/Storage/StreamWrapper.php 0% <0%> (ø) 14% <0%> (-5%) ⬇️
apps/files_external/lib/Lib/Storage/AmazonS3.php 0% <0%> (ø) 110% <0%> (+18%) ⬆️
lib/private/Files/ObjectStore/S3ObjectTrait.php 85.71% <0%> (ø) 3% <0%> (?)
lib/private/Security/IdentityProof/Signer.php 80.64% <0%> (+0.64%) 7% <0%> (ø) ⬇️
...ib/private/Files/ObjectStore/S3ConnectionTrait.php 57.77% <0%> (+3.61%) 23% <0%> (+1%) ⬆️

@icewind1991
Copy link
Member Author

@rullzer @schiessle please review

@rullzer
Copy link
Member

rullzer commented Oct 9, 2017

Why?

This only fixes something that never worked before right (>5gb uploads)? So it is a new feature. Why backport? Also I'm really not that comfortable merging such huge changes into a maintenance release.

@karlitschek
Copy link
Member

This needs to be backported because of an external requirement.

@icewind1991 icewind1991 merged commit df2fa2f into stable12 Oct 9, 2017
@icewind1991 icewind1991 deleted the aws-sdk-12 branch October 9, 2017 16:05
@MorrisJobke MorrisJobke mentioned this pull request Nov 20, 2017
1 task
@MorrisJobke
Copy link
Member

As this does not have a single review and it caused serious damage on a minor upgrade from 12.0.3 to 12.0.4 (see #7569) I will open a revert for this PR.

@MorrisJobke
Copy link
Member

As this does not have a single review and it caused serious damage on a minor upgrade from 12.0.3 to 12.0.4 (see #7569) I will open a revert for this PR.

@icewind1991 Could you take care of this as it seems to be non-trivial, because other backports like #7186 and #7079 went in as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants