-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12] Update aws sdk + s3 improvements #6737
Conversation
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Xenopathic to be a potential reviewer. |
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Codecov Report
@@ Coverage Diff @@
## stable12 #6737 +/- ##
==============================================
- Coverage 53.78% 53.76% -0.02%
+ Complexity 22559 22554 -5
==============================================
Files 1383 1384 +1
Lines 86586 86546 -40
Branches 1328 1328
==============================================
- Hits 46566 46531 -35
+ Misses 40020 40015 -5
|
@rullzer @schiessle please review |
Why? This only fixes something that never worked before right (>5gb uploads)? So it is a new feature. Why backport? Also I'm really not that comfortable merging such huge changes into a maintenance release. |
This needs to be backported because of an external requirement. |
As this does not have a single review and it caused serious damage on a minor upgrade from 12.0.3 to 12.0.4 (see #7569) I will open a revert for this PR. |
@icewind1991 Could you take care of this as it seems to be non-trivial, because other backports like #7186 and #7079 went in as well. |
Backport of #4410 and #6602