Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable12] Fix notifications order #93

Merged
merged 2 commits into from
Sep 27, 2017
Merged

[stable12] Fix notifications order #93

merged 2 commits into from
Sep 27, 2017

Conversation

nickvergessen
Copy link
Member

Backport #91

@nickvergessen
Append notifications on initial fetch
89b7677 
but prepend them when grabbing later

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Resort the list by timestamp after adding new items on the fly
29aef88 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 12.0.4 milestone Sep 26, 2017
MorrisJobke
MorrisJobke approved these changes Sep 27, 2017
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke merged commit 5dc2983 into stable12 Sep 27, 2017
@MorrisJobke MorrisJobke deleted the backport-91-fix-notifications-order branch September 27, 2017 13:35
@MorrisJobke MorrisJobke mentioned this pull request Nov 20, 2017
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

Assignees
No one assigned
Labels
3. to review bug feature: frontend 🖌️
Projects
None yet
Milestone
Nextcloud 12.0.4
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @MorrisJobke